This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Added Zend 3 support#21
Open
goldforg wants to merge 19 commits into
Open
Conversation
vgarvardt
reviewed
Jan 28, 2022
vgarvardt
left a comment
Owner
There was a problem hiding this comment.
Thank you! Will check the rest later today or tomorrow.
|
|
||
| Simple Migrations for Zend Framework 2. Project originally based on [ZendDbMigrations](https://github.com/vadim-knyzev/ZendDbMigrations) but module author did not response for issues and pull-requests so fork became independent project. | ||
|
|
||
| ## Added Zend 3 Support 28.01.2022 |
Owner
There was a problem hiding this comment.
Please extract this to the new CHANGELOG.md under the ## Unreleased - will tag it with the version as soon as it will be ready for the release
| private $sql = []; | ||
| private $metadata; | ||
| private $writer; | ||
| protected $serviceLocator; |
Owner
There was a problem hiding this comment.
Suggested change
| protected $serviceLocator; | |
| /** @var ServiceLocatorInterface */ | |
| protected $serviceLocator; |
Author
|
Hi Vladimir,
Do I need to create CHANGELOG.md or is there one you did not commit yet?
Sincerely,
Rolands
piektd., 2022. g. 28. janv., plkst. 16:56 — lietotājs Vladimir Garvardt (<
***@***.***>) rakstīja:
… ***@***.**** commented on this pull request.
Thank you! Will check the rest later today or tomorrow.
------------------------------
In README.md
<#21 (comment)>
:
> @@ -2,6 +2,13 @@
Simple Migrations for Zend Framework 2. Project originally based on [ZendDbMigrations](https://github.com/vadim-knyzev/ZendDbMigrations) but module author did not response for issues and pull-requests so fork became independent project.
+## Added Zend 3 Support 28.01.2022
Please extract this to the new CHANGELOG.md under the ## Unreleased -
will tag it with the version as soon as it will be ready for the release
------------------------------
In src/ZfSimpleMigrations/Library/AbstractMigration.php
<#21 (comment)>
:
>
abstract class AbstractMigration implements MigrationInterface
{
private $sql = [];
private $metadata;
private $writer;
+ protected $serviceLocator;
⬇️ Suggested change
- protected $serviceLocator;
+ /** @var ServiceLocatorInterface */
+ protected $serviceLocator;
—
Reply to this email directly, view it on GitHub
<#21 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXX5XDJHEJ26TOYZOTOPE3UYK4B7ANCNFSM5NA66ELA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
@goldforg create it please |
Author
|
Hi Vladimir,
I added CHANGELOG.md to your library under ## unreleased.
Sincerely,
Rolands
piektd., 2022. g. 28. janv., plkst. 18:09 — lietotājs Vladimir Garvardt (<
***@***.***>) rakstīja:
… @goldforg <https://github.com/goldforg> create it please
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXX5XG2R2PTISL2WQ44ZHDUYLEVZANCNFSM5NA66ELA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Tests are not passing - I think something in composer needs to be updated. Currently it is locked to zf2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Zend 3 support to the library and benefit that in older migration scripts it is possible to use getServiceLocator method.