Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Added Zend 3 support#21

Open
goldforg wants to merge 19 commits into
vgarvardt:masterfrom
goldforg:master
Open

Added Zend 3 support#21
goldforg wants to merge 19 commits into
vgarvardt:masterfrom
goldforg:master

Conversation

@goldforg

Copy link
Copy Markdown

Added Zend 3 support to the library and benefit that in older migration scripts it is possible to use getServiceLocator method.

@vgarvardt vgarvardt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will check the rest later today or tomorrow.

Comment thread README.md Outdated

Simple Migrations for Zend Framework 2. Project originally based on [ZendDbMigrations](https://github.com/vadim-knyzev/ZendDbMigrations) but module author did not response for issues and pull-requests so fork became independent project.

## Added Zend 3 Support 28.01.2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extract this to the new CHANGELOG.md under the ## Unreleased - will tag it with the version as soon as it will be ready for the release

private $sql = [];
private $metadata;
private $writer;
protected $serviceLocator;

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected $serviceLocator;
/** @var ServiceLocatorInterface */
protected $serviceLocator;

@goldforg

goldforg commented Jan 28, 2022 via email

Copy link
Copy Markdown
Author

@vgarvardt

vgarvardt commented Jan 28, 2022

Copy link
Copy Markdown
Owner

@goldforg create it please

@goldforg

goldforg commented Jan 31, 2022 via email

Copy link
Copy Markdown
Author

@vgarvardt

Copy link
Copy Markdown
Owner

Tests are not passing - I think something in composer needs to be updated. Currently it is locked to zf2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants