Fix: issue #4 and #5#6
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements thread-safety for shell aliases using a sync.RWMutex and ensures system command scanning is idempotent via sync.Once. It also improves the install.sh script's error handling and adds a local testing target with a mock server to the justfile. Review feedback highlights a non-POSIX head flag in the installer that breaks on macOS, recommends reverting the GOAMD64 target to v3 for broader hardware compatibility, and notes that the wget path in the installer bypasses the new error handling logic.
| "https://api.github.com/repos/${REPO}/releases/latest") | ||
| "${IRIS_API_URL}/repos/${REPO}/releases/latest") | ||
| http_code=$(echo "${http_response}" | tail -1) | ||
| releases=$(echo "${http_response}" | head -n -1) |
There was a problem hiding this comment.
The -n -1 flag for head is a GNU extension and is not POSIX-compliant. This will cause the installer to fail on systems using BSD head (such as macOS) with an illegal line count -- -1 error. To ensure portability across different Unix-like systems, use sed '$d' to remove the last line of the output.
| releases=$(echo "${http_response}" | head -n -1) | |
| releases=$(echo "${http_response}" | sed '$d') |
| [group('build')] | ||
| optimized-build: | ||
| @GOAMD64=v3 go build -pgo=auto -ldflags="-s -w" -trimpath -o iris main.go | ||
| @GOAMD64=v4 go build -ldflags="-s -w" -trimpath -o iris main.go |
There was a problem hiding this comment.
Targeting GOAMD64=v4 for the 'optimized' build significantly limits hardware compatibility, as it requires AVX-512 support which is absent in many modern consumer CPUs. This may lead to SIGILL (Illegal Instruction) crashes for users running the binary on older or mid-range hardware. v3 (AVX2) is generally considered the standard target for optimized x86_64 builds as it covers most CPUs from the last decade.
@GOAMD64=v3 go build -ldflags="-s -w" -trimpath -o iris main.go
| ${GITHUB_TOKEN:+--header "Authorization: Bearer ${GITHUB_TOKEN}"} \ | ||
| "https://api.github.com/repos/${REPO}/releases/latest") | ||
| "${IRIS_API_URL}/repos/${REPO}/releases/latest") | ||
| http_code="200" |
There was a problem hiding this comment.
In the wget code path, the http_code is hardcoded to 200. This bypasses the specific error handling logic implemented for curl (lines 108-114), which provides helpful messages for 404 (no releases) or 403 (rate limiting) errors. While set -e will stop the script on a wget failure, the user will miss the context-specific error messages.
1 participant
Issue [BUG] Install #4: currently there is no official release yet so we cant download from installer
I added an installer debugger here to test (bb9a750)
Issue [BUG] Crash #5: my another library fuzzy has a logic bug so it causes crash, fix 8ad579c
Other: