workflows: add some os things to sandbox whitelist, only restrict callables#143
Merged
Conversation
…lables shutil, pathlib and third-party rich were both failing to import due to sandbox interactions with os. I'm adding getenv, getcwd, and PathLike to the whitelist. I've also made it so that we only restrict callables, since we were restricting the set `os.supports_dir_fd` which was breaking some stuff. (We could also have added it to the whitelist but this seems a little more general, though we will want to further generalize it later.)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The sandbox allowlist now permits os.getcwd(); update the test to match the new behavior instead of asserting it raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil, pathlib and third-party rich were both failing to import due
to sandbox interactions with os.
I'm adding getenv, getcwd, and PathLike to the whitelist.
I've also made it so that we only restrict callables, since we were
restricting the set
os.supports_dir_fdwhich was breaking somestuff. (We could also have added it to the whitelist but this seems a
little more general, though we will want to further generalize it
later.)