feat(sandbox,vercel/sandbox): support new image parameter#232
Draft
marc-vercel wants to merge 3 commits into
Draft
feat(sandbox,vercel/sandbox): support new image parameter#232marc-vercel wants to merge 3 commits into
marc-vercel wants to merge 3 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AndyW22
reviewed
Jun 25, 2026
| WithFetchOptions, | ||
| ): Promise<Sandbox & AsyncDisposable> { | ||
| "use step"; | ||
| if ( |
Collaborator
There was a problem hiding this comment.
Can we check this on a type level? we should be able to override the method definition
Collaborator
Author
There was a problem hiding this comment.
Fixed in 4f23798
Note that it was not straightforward and I had to add more code than I expected, but IMO this looks better than before. Nice catch!
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new image parameter.
CLI
Add a new image parameter for the
sandbox createcommand. It cannot be used with--runtime. Example:SDK
SDK also supports this new parameter in the create command. Like the CLI, it cannot be used with the
runtimeparameter. Example: