fix(vercel): honor author-supplied runtime instead of forcing the eve image#257
Open
serhiizghama wants to merge 2 commits into
Open
fix(vercel): honor author-supplied runtime instead of forcing the eve image#257serhiizghama wants to merge 2 commits into
serhiizghama wants to merge 2 commits into
Conversation
Signed-off-by: serhiizghama <zmrser@gmail.com>
Signed-off-by: serhiizghama <zmrser@gmail.com>
|
@serhiizghama is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239.
vercel({ runtime: "python3.13" })was silently ignored.createVercelEveImageSandboxalways spread__image: "vercel/eve:latest"onto the create call, and since__imagetakes precedence overruntimein the SDK, the requested runtime never reached the sandbox — no error, no warning, just the default image.The eve image is only meant to be a default base, so I made it conditional: when the author supplies a
runtime, the image is left off and the runtime flows through toSandbox.createas-is. This mirrors howsourcealready works as a template base —runtimebecomes the base for the template create and is stripped from session creates by the existing snapshot path. The base setup script only requires bash, which the supported runtimes provide, so nothing else changes.There was already a test asserting runtime reaches the SDK, but it injected a mock
createSandboxthat bypasses the__imagebinding, so the real drop went unnoticed. Added a test that goes through the default binding and checks the runtime is forwarded and__imageis absent.