Fix errors caused by the switch to VESC 7.00.#94
Open
mikeller wants to merge 3 commits into
Open
Conversation
Fix the problem of the display not working after a cold start. Add endless loop to 'main'.
Fixed 1 file(s) based on 1 unresolved review comment. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility fix release for VESC firmware 7.00.
Changes
Fix: Cold-boot dark display (I2C first-message bug)
On VESC firmware 7.00, the first
i2c-tx-rxcall afteri2c-starton a cold boot is silently dropped and never reaches the I2C device. The HT16K33 display controller's oscillator-enable command (0x21) was never delivered, leaving the oscillator stopped and the display permanently dark.Workaround: send the oscillator-enable command twice in
peripherals_setup; the first write is sacrificial (absorbed by the bug), the second reaches the controller.Fix: Package crash on second and subsequent boots (
move-to-flash→@const-start)VESC 7.00 re-evaluates package source on every boot but preserves the flash heap from the previous session. The previous
move-to-flashcalls conflicted with the already-populated flash heap and caused an abort before any threads were spawned.Fix: replaced all
move-to-flashcalls with the@const-start/@const-endblock syntax, which is the correct mechanism for VESC 7.00.Docs