[FEAT] Auth 관련 API & 상태 관리 초기 세팅#88
Merged
Merged
Conversation
waldls
requested review from
a team,
HiJuwon,
gaeulzzang,
jinj00oo and
sunhwaaRj
as code owners
July 27, 2025 12:04
HiJuwon
approved these changes
Jul 27, 2025
HiJuwon
left a comment
HiJuwon
left a comment
Member
There was a problem hiding this comment.
수고하셨습니다, 나중에 백엔드 측에서 서버 배포하면 코드 실행해보고 문제 있을 경우 추후 수정하면 될 것 같습니다~~!!
gaeulzzang
approved these changes
Jul 27, 2025
gaeulzzang
left a comment
gaeulzzang
left a comment
Collaborator
There was a problem hiding this comment.
로그인부터 토큰 재발급까지 수고 많으셨습니다 ❤️
| const setItem = (value: unknown) => { | ||
| try { | ||
| // 값을 JSON 문자열로 변환해서 저장 | ||
| window.localStorage.setItem(key, JSON.stringify(value)); |
Collaborator
There was a problem hiding this comment.
P3: 혹시 json으로 저장하는 이유 알 수 있을까요??
Member
Author
There was a problem hiding this comment.
accessToken은 문자열이지만, 혹시 모를 타입 변화나 재사용 상황에 대비해서 JSON.stringify()로 안전하게 저장했습니다!
sunhwaaRj
approved these changes
Jul 27, 2025
sunhwaaRj
left a comment
sunhwaaRj
left a comment
Collaborator
There was a problem hiding this comment.
공통 부분 담당해주셔서 감사합니다!! await axiosInstance.get 으로 uri 적용하겠습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
apis/axios.tsaxiosInstance기본 인스턴스 생성 및 baseURL 설정apis/auth.tstypes/auth.tshooks/useLocalStorage.tssetItem,getItem,removeItem기능 제공pages/onboarding/GoogleLoginRedirect.tsx📸 스크린샷 or 실행영상
💬 To Reviewers