[UI] 설정 사이드바 UI 구현#65
Merged
Merged
Conversation
- 팀목록, 팀멤버, 나의프로필 아이콘 및 호버 아이콘 추가 - 팀목록 일반 아이콘이 없어 디자인 팀에 요청 후 추가예정
- 페이지 경로가 '/working/setting'일 시 SettingSidebar 렌더링
- 및 사이드바 내부 스타일링 수정 : SidebarItem 상위 div들을 하나로 통합
- 사이드바 아이템 클릭시 알맞는 페이지로 라우팅
jinj00oo
requested review from
HiJuwon,
gaeulzzang,
sunhwaaRj and
waldls
as code owners
July 18, 2025 08:45
sunhwaaRj
approved these changes
Jul 18, 2025
sunhwaaRj
left a comment
sunhwaaRj
left a comment
Collaborator
There was a problem hiding this comment.
수고하셨습니다~~ 기본 사이드바 연결도 변경된 주소에 맞게 바꿔주시면 될 것 같아요 수고하셨습니다 👏👏
Collaborator
Author
|
수정하겠습니다!! 피드백 감사합니다. |
- 및 이동 경로를 명확화하여 기본 경로에서 한 번 더 리다이렉트하는 것을 방지 -> 화면 깜빡임 방지
…into feat/#63-setting-sidebar-ui
Member
|
늦게 확인했습니다. 수고 많으셨습니다~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
ProtectedLayout에서 경로에 따른 사이드바 조건부 렌더링을 추가하였습니다.workspace/setting이면SettingSidebar을 렌더링하도록 하였습니다.📸 스크린샷 or 실행영상
VECO.-.Chrome.2025-07-18.17-39-06.mp4
💬 To Reviewers