[FEAT] 로딩 페이지 UX 개선#189
Merged
Merged
Conversation
waldls
requested review from
HiJuwon,
gaeulzzang,
jinj00oo and
sunhwaaRj
as code owners
sunhwaaRj
approved these changes
Aug 20, 2025
sunhwaaRj
left a comment
sunhwaaRj
left a comment
Collaborator
There was a problem hiding this comment.
피드백 반영 감사합니다. 훨씬 로딩중이라는 것이 명확히 보여요
jinj00oo
approved these changes
Aug 20, 2025
jinj00oo
left a comment
jinj00oo
left a comment
Collaborator
There was a problem hiding this comment.
일관된 로딩스피너 처리 좋은 듯 합니다~ 피드백 빠른 적용 멋있습니다! 👍
| import { useNavigate, useParams, useSearchParams } from 'react-router-dom'; | ||
| import { useLocalStorage } from '../../hooks/useLocalStorage'; | ||
| import { LOCAL_STORAGE_KEY } from '../../constants/key'; | ||
| import Loading from '../Loading'; |
Collaborator
There was a problem hiding this comment.
P2:
- 로딩 스피너같은 경우는 pages 폴더가 아닌 components 폴더에 있는 게 역할 분리에 좀 더 적절한 것 같습니다.
- 이름을 LoadingSpinner 같이 좀 더 구체적으로 네이밍하는 게 좋다는 생각이 드네요. 그냥 Loading이라고 하면 어떤 역할을 하는지 헷갈릴 수 있을 것 같습니다.
새로 만드신 게 아니라 원래 있던 걸로 확인되는데.. ㅎㅎ 여기에 리뷰를 남겨도 되는지 모르겠지만, 혹시 역할 정리에 도움이 될까 싶어 코멘트 남겨봅니다!
Member
Author
There was a problem hiding this comment.
넵 알겠습니다! 가을님께서 이전에 작업해두신 걸 제가 활용한 부분이라, 가을님 동의 얻으면 파일명과 경로 수정해서 다시 push 해두겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
TokenLoading페이지,InviteLoading페이지,WorkspaceComplete페이지의 UX 개선했습니다.📸 스크린샷 or 실행영상
1. TokenLoading 페이지
TokenLoading.mp4
2. InviteLoading 페이지
InviteLoading.mp4
3. WorkspaceComplete 페이지
WorkspaceComplete.mp4
💬 To Reviewers