-
Notifications
You must be signed in to change notification settings - Fork 5
[FEAT] 디테일 잡기 (무한스크롤, 스켈레톤 UI) #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d5ef673
#119 [FEAT] 리스트 아이템 스켈레톤 ui
sunhwaaRj 37b9046
#119 [FEAT] 스켈레톤 ui 목록
sunhwaaRj 3acb4d0
#119 [MOD] 스켈레톤 아이템 개수 입력
sunhwaaRj d5b77d2
#119 [FEAT] 목표 무한스크롤 훅
sunhwaaRj adfb521
#119 [FEAT] 이슈 무한스크롤 훅
sunhwaaRj 0eb3d3f
#119 [FEAT] 외부 무한스크롤 훅
sunhwaaRj 525aee6
#119 [FEAT] 무한스크롤 데이터 append 용 함수
sunhwaaRj ff09153
#119 [FIX] cursor 값 일관되도록
sunhwaaRj 5ceea34
#119 [FEAT] 목표 리스트 무한스크롤 구현
sunhwaaRj 715a3ac
#119 [FEAT] 이슈 리스트 무한스크롤 구현
sunhwaaRj 8ee148d
Merge branch 'develop' of https://github.com/vecosystem/VECO_Frontend…
sunhwaaRj 9461275
#119 [FEAT] 에러 페이지 연결
sunhwaaRj 7304a88
#119 [ADD] 함수 주석 추가
sunhwaaRj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| const ListItemSkeleton = () => { | ||
| return ( | ||
| <div className="flex justify-between items-center h-[5.6rem] px-[3.2rem] -mx-[3.2rem] animate-pulse"> | ||
| <div className="flex items-center gap-[0.8rem]"> | ||
| <div className="bg-gray-200 w-[6rem] h-[1.8rem] ml-[2.4rem] rounded-full" /> | ||
| <div className="bg-gray-200 w-[2.4rem] h-[2.4rem] rounded-md" /> | ||
| <div className="bg-gray-200 w-[12rem] h-[1.8rem] rounded-full" /> | ||
| </div> | ||
| <div className="flex gap-[2.4rem] items-center"> | ||
| <div className="flex gap-[2.4rem] items-center"> | ||
| <div className="bg-gray-200 w-[12rem] h-[1.8rem] rounded-full" /> | ||
| <div className="bg-gray-200 w-[12rem] h-[1.8rem] rounded-full" /> | ||
| </div> | ||
| <div className="flex gap-[0.8rem] items-center relative"> | ||
| <div className="bg-gray-200 w-[2.4rem] h-[2.4rem] rounded-full z-2" /> | ||
| <div className="bg-gray-200 w-[8rem] h-[1.8rem] rounded-full" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ListItemSkeleton; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import ListItemSkeleton from './ListViewItemSkeleton'; | ||
|
|
||
| const ListViewItemSkeletonList = ({ count = 10 }: { count?: number }) => { | ||
| return ( | ||
| <> | ||
| {new Array(count).fill(0).map((_, idx) => ( | ||
| <ListItemSkeleton key={idx} /> | ||
| ))} | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default ListViewItemSkeletonList; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| type ListItem = { | ||
| id: number; | ||
| }; | ||
|
|
||
| type GroupedList<T extends ListItem> = { | ||
| key: string; | ||
| items: T[]; | ||
| }; | ||
|
|
||
| export function mergeGroups<T extends ListItem>(groups: GroupedList<T>[]): GroupedList<T>[] { | ||
| const merged: { [key: string]: T[] } = {}; | ||
|
|
||
| for (const group of groups) { | ||
| if (!merged[group.key]) merged[group.key] = []; | ||
| merged[group.key] = [...merged[group.key], ...group.items]; | ||
| } | ||
|
|
||
| return Object.entries(merged).map(([key, items]) => ({ key, items })); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: 반복문으로 10개 미리 보여주는거 너무 좋은데요?? 저도 적용해봐야겠네요 👍