[FEAT] 목록 조회 API 구조#112
Merged
Merged
Conversation
…into feature/#80-listview-type
sunhwaaRj
requested review from
HiJuwon,
gaeulzzang,
jinj00oo and
waldls
as code owners
August 1, 2025 12:37
Collaborator
Author
|
@gaeulzzang |
HiJuwon
reviewed
Aug 1, 2025
HiJuwon
left a comment
HiJuwon
left a comment
Member
There was a problem hiding this comment.
넵 확인했습니다. 상태나 진행중 변수명 변경에 대해 노티 주셔서 감사합니다. 참고하겠습니다.
개인적으로는 isLoading 시 스켈레톤 ui 적용하면 좋을 것 같긴 하네요
gaeulzzang
approved these changes
Aug 1, 2025
gaeulzzang
left a comment
gaeulzzang
left a comment
Collaborator
There was a problem hiding this comment.
빌드 오류 해결했습니다~
무한스크롤은 useInfiniteQuery로 적용하는게 좋은 것 같은데 어떻게 생각하시나요??
Comment on lines
+25
to
+28
| return useQuery({ | ||
| queryKey: [queryKey.GOAL_LIST, teamId, params], | ||
| queryFn: () => getGoalList({ teamId }, params), | ||
| }); |
Collaborator
There was a problem hiding this comment.
P2: useInfiniteQuery 사용해서 무한 스크롤로 구현하는게 좋지 않을까요?
waldls
approved these changes
Aug 1, 2025
waldls
left a comment
waldls
left a comment
Member
There was a problem hiding this comment.
p2 : 위에서 말씀해주신 바와 같이 무한 스크롤 적용 & 스켈레톤 UI로 구현 리팩토링 시 추가해주셔도 좋을 것 같습니다! 다뤄야 할 코드 파일들이 많아 복잡하셨을 것 같아요...ㅠ.ㅠ 수고하셨습니다 👍🏻👍🏻
Collaborator
Author
넵 저도 좋은 것 같습니다 추후 적용하겠습니다 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
진행 중변수 DOING -> IN_PROGRESS 로 변경추가 UI 작업
훅 완료 -> 코드 적용 완료 -> 연동 완료
리스트 불러오기
연동완료코드적용 완료코드적용 완료(구조 수정 적용 예정)훅 완료(구조 수정 적용 예정)삭제
코드적용 완료코드적용 완료코드적용 완료훅 완료📸 스크린샷 or 실행영상
연동 완료 요소
80.mp4
💬 To Reviewers