Skip to content

README.md: address linter warnings re: unkeyed fields and redundant control flow#623

Open
ajschlosser wants to merge 2 commits into
veandco:masterfrom
ajschlosser:master
Open

README.md: address linter warnings re: unkeyed fields and redundant control flow#623
ajschlosser wants to merge 2 commits into
veandco:masterfrom
ajschlosser:master

Conversation

@ajschlosser

Copy link
Copy Markdown

The larger example (in both the master as well as v0.4.x branches) produces two linter warnings:

  • line 24: "github.com/veandco/go-sdl2/sdl.Rect struct literal uses unkeyed fields"
  • line 37: "redundant break statementS1023"

This pull request updates line 24 to specify the sdl.Rect fields (X, Y, W, and H) and deletes line 37 (removing the redundant/unnecessary break statement).

In eliminating the linter warnings, people new to the language or library, and relying on the example for their initial exposure, will have more confidence that they are on the right track.

Thanks for your consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant