README.md: address linter warnings re: unkeyed fields and redundant control flow#623
Open
ajschlosser wants to merge 2 commits into
Open
README.md: address linter warnings re: unkeyed fields and redundant control flow#623ajschlosser wants to merge 2 commits into
ajschlosser wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The larger example (in both the
masteras well asv0.4.xbranches) produces two linter warnings:This pull request updates line 24 to specify the sdl.Rect fields (
X,Y,W, andH) and deletes line 37 (removing the redundant/unnecessarybreakstatement).In eliminating the linter warnings, people new to the language or library, and relying on the example for their initial exposure, will have more confidence that they are on the right track.
Thanks for your consideration.