Make missing-state keyframe error readable in both themes and move it to the top (#3385)#3394
Merged
Merged
Conversation
… to the top (#3385) The 'Could not find state or animation' label in StateView used Frb.Brushes.Error as a Background. That color flips lightness between themes (light: dark red, dark: light pink), so the default near-white foreground was unreadable in dark mode, and no single foreground reads on it in both themes. Render it the way every other error in the app does: as bold Error-colored foreground text with no background block. Also moved it from Grid.Row 4 (under the In/Out field) to Grid.Row 0, above the state ComboBox, since it is critical context, shifting the other rows down. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the missing-state keyframe error label in the animation keyframe editor (
StateView.xaml):Frb.Brushes.Erroras a Background (a light pink in dark mode) with the default near-white foreground — unreadable in dark mode.Frb.Colors.Errorflips lightness between themes (light: dark red#C62828, dark: light pink#EF9A9A), so no single foreground reads on it as a background. Now it renders the way every other error in the app does: bold Error-colored foreground text, no background block — theme-safe by construction.Grid.Row="4"(under the In/Out field) toGrid.Row="0", above the state ComboBox, since it is critical context. Other rows shifted down by one.Note on approach
The issue offered two options: pick a foreground that reads on the pink background, or use a dedicated error style. I took the second — a hand-picked foreground can't contrast both a dark-red and a light-pink background, so the foreground-text treatment is the robust, convention-matching fix.
Manual test: needed — visual only (XAML). Open a project with an animation keyframe referencing a missing state; confirm the red "Could not find state or animation" text appears at the top of the keyframe editor and is readable in both light and dark themes.
Closes #3385
🤖 Generated with Claude Code