Repository navigation
Conversation
Correct five broken Wimlib README links, install the selected review skills, and include the shared documentation-audit checker fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Broken batch control flow and unsafe temporary-directory cleanup remain, alongside audit and instructional correctness issues.
10 open issues
What changed in this PR
Adds development and review skills to the Driver Automation Tool repository and repairs vendored documentation links.
Changes:
- Adds five skills with reference guides and batch templates.
- Introduces documentation-drift checks and focused regression coverage.
- Corrects five Wimlib README links.
| File | Description |
|---|---|
| Driver Automation Tool/Tools/Wimlib/README.WINDOWS.txt | Corrects the main README link. |
| Driver Automation Tool/Tools/Wimlib/README.txt | Corrects bundled documentation links. |
| .github/skills/pester-should-migration/SKILL.md | Adds assertion migration guidance. |
| .github/skills/pester-should-migration/references/assertion-map.md | Maps classic assertions to v6 forms. |
| .github/skills/github-release/SKILL.md | Adds a release preparation workflow. |
| .github/skills/github-release/references/semver-rules.md | Documents versioning decisions. |
| .github/skills/github-release/references/commit-classification.md | Guides changelog classification. |
| .github/skills/github-actions-hardening/SKILL.md | Adds workflow security review guidance. |
| .github/skills/github-actions-hardening/references/triggers-and-privilege.md | Explains trigger trust boundaries. |
| .github/skills/github-actions-hardening/references/supply-chain.md | Covers action and runner security. |
| .github/skills/github-actions-hardening/references/report-format.md | Defines security report formatting. |
| .github/skills/github-actions-hardening/references/permissions-and-tokens.md | Documents token and secret handling. |
| .github/skills/github-actions-hardening/references/injection.md | Explains script-injection prevention. |
| .github/skills/docs-sync-audit/tests/test_docs_drift.py | Adds false-positive regression coverage. |
| .github/skills/docs-sync-audit/SKILL.md | Defines documentation audit procedures. |
| .github/skills/docs-sync-audit/scripts/docs_drift.py | Implements documentation-drift checks. |
| .github/skills/batch-files/SKILL.md | Adds batch scripting guidance. |
| .github/skills/batch-files/references/windows-subsystem-on-linux.md | Collects WSL resources. |
| .github/skills/batch-files/references/tools-and-resources.md | Lists Windows administration tools. |
| .github/skills/batch-files/references/msys2.md | Adds MSYS2 references. |
| .github/skills/batch-files/references/cygwin.md | Adds Cygwin integration guidance. |
| .github/skills/batch-files/references/batch-files-and-functions.md | Documents batch scripting techniques. |
| .github/skills/batch-files/assets/task.txt | Adds an automation task template. |
| .github/skills/batch-files/assets/library.txt | Adds a reusable function template. |
| .github/skills/batch-files/assets/executable.txt | Adds a command-line tool template. |
Review effort: Balanced
Comment on lines
+457
to
+458
| if /i "%~1"=="--target" set "_TARGET=%~2" & shift | ||
| if /i "%~1"=="--help" call :usage & exit /b 0 |
Comment on lines
+51
to
+53
| if "%_parOneMyTool%"=="/?" call :_showHelpMyTool & goto _removeBatchVariablesMyTool | ||
| if /i "%_parOneMyTool%"=="-h" call :_showHelpMyTool & goto _removeBatchVariablesMyTool | ||
| if /i "%_parOneMyTool%"=="--help" call :_showHelpMyTool & goto _removeBatchVariablesMyTool |
Comment on lines
+36
to
+44
| if "%_funcMyLib%"=="/?" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="-h" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="--help" call :_showHelpMyLib & goto _removeBatchVariablesMyLib | ||
|
|
||
| if /i "%_funcMyLib%"=="trimWhitespace" call :_trimWhitespaceMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="toLower" call :_toLowerMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="getTimestamp" call :_getTimestampMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="logMessage" call :_logMessageMyLib & goto _removeBatchVariablesMyLib | ||
| if /i "%_funcMyLib%"=="padRight" call :_padRightMyLib & goto _removeBatchVariablesMyLib |
Comment on lines
+50
to
+52
| if "%_parOneMyTask%"=="/?" call :_showHelpMyTask & goto _removeBatchVariablesMyTask | ||
| if /i "%_parOneMyTask%"=="-h" call :_showHelpMyTask & goto _removeBatchVariablesMyTask | ||
| if /i "%_parOneMyTask%"=="--help" call :_showHelpMyTask & goto _removeBatchVariablesMyTask |
| for /f "skip=1 tokens=* delims=" %%a in ('findstr /n "^" "%~f0"') do ( | ||
| set "_line=%%a" | ||
| setlocal EnableDelayedExpansion | ||
| set "_lineNum=!_line:~0,2!" |
| set _checkParTwoMyTask= | ||
| REM Append new variables above this line. | ||
|
|
||
| if EXIST "%_tmpDirMyTask%" rmdir /S /Q "%_tmpDirMyTask%" >nul 2>nul |
| f"documents `make {target}`, which is not a target in the Makefile.", | ||
| source="Makefile") | ||
| for whole, inner in CMD_SCRIPT.findall(line): | ||
| candidate = (inner or whole).lstrip("./") |
|
|
||
| ````PowerShell | ||
| # Create PR body using here-string (preserves actual newlines, not escape sequences) | ||
| $prBody = @" |
Comment on lines
+73
to
+80
| permissions: | ||
| pull-requests: write | ||
| jobs: | ||
| comment: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/download-artifact@<sha> # data only, not executed | ||
| # post results, using the trusted token — but never execute the artifact |
Comment on lines
+168
to
+169
| | `$p \| Should -FileContentMatch 're'` | `(Get-Content $p -Raw) \| Should-MatchString 're'` | | ||
| | `$p \| Should -FileContentMatchExactly 're'` | `(Get-Content $p -Raw) \| Should-MatchString 're' -CaseSensitive` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actions-hardening,pester-should-migration,docs-sync-audit,github-release, andbatch-files.Validation
git diff --checkpassed.