Skip to content

Install review skills and update checksums - #27

Open
vartaxe wants to merge 2 commits into
mainfrom
copilot/review-and-skills-2026-10-17
Open

vartaxe wants to merge 2 commits into
mainfrom
copilot/review-and-skills-2026-10-17

Conversation

@vartaxe

@vartaxe vartaxe commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Install github-actions-hardening, pester-should-migration, docs-sync-audit, github-release, and batch-files.
  • Regenerate CHECKSUMS.txt for all maintained skill assets.
  • Fix documentation-audit false positives for skill-relative scripts, code spans/fences, PowerShell environment reads, and URL-encoded paths.

Validation

  • Windows PowerShell 5.1 / Pester 6.2.0: 236 passed, 0 failed.
  • 119 checksum entries verified; focused docs-drift test passed.
  • git diff --check passed.

vartaxe and others added 2 commits October 17, 2026 11:45
Add the selected review and workflow skills, checksum all maintained assets, and include the shared documentation-audit checker fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Execution-blocking batch errors, unsafe cleanup and interpolation, and incomplete release preparation remain unresolved.

13 open issues
What changed in this PR

Adds five skills for repository maintenance and review without changing the production PowerShell script.

Changes:

  • Adds review guidance, references, and batch templates.
  • Adds a documentation-drift checker with focused regression coverage.
  • Updates checksums for the new skill assets.
File Description
CHECKSUMS.txt Adds skill asset hashes.
.github/​skills/​pester-should-migration/​SKILL.md Adds assertion migration guidance.
.github/​skills/​pester-should-migration/​references/​assertion-map.md Maps assertion conversions.
.github/​skills/​github-release/​SKILL.md Defines release preparation workflow.
.github/​skills/​github-release/​references/​semver-rules.md Documents versioning decisions.
.github/​skills/​github-release/​references/​commit-classification.md Classifies release changes.
.github/​skills/​github-actions-hardening/​SKILL.md Adds workflow security guidance.
.github/​skills/​github-actions-hardening/​references/​triggers-and-privilege.md Explains workflow trust boundaries.
.github/​skills/​github-actions-hardening/​references/​supply-chain.md Covers action and artifact security.
.github/​skills/​github-actions-hardening/​references/​report-format.md Defines security report format.
.github/​skills/​github-actions-hardening/​references/​permissions-and-tokens.md Covers token permissions.
.github/​skills/​github-actions-hardening/​references/​injection.md Documents injection prevention.
.github/​skills/​docs-sync-audit/​tests/​test_docs_drift.py Adds false-positive regression coverage.
.github/​skills/​docs-sync-audit/​SKILL.md Defines documentation audits.
.github/​skills/​docs-sync-audit/​scripts/​docs_drift.py Implements documentation checks.
.github/​skills/​batch-files/​SKILL.md Adds batch scripting guidance.
.github/​skills/​batch-files/​references/​windows-subsystem-on-linux.md Links WSL resources.
.github/​skills/​batch-files/​references/​tools-and-resources.md Catalogs Windows tools.
.github/​skills/​batch-files/​references/​msys2.md Documents MSYS2 resources.
.github/​skills/​batch-files/​references/​cygwin.md Documents Cygwin integration.
.github/​skills/​batch-files/​references/​batch-files-and-functions.md Collects batch scripting techniques.
.github/​skills/​batch-files/​assets/​task.txt Adds scheduled-task template.
.github/​skills/​batch-files/​assets/​library.txt Adds reusable function template.
.github/​skills/​batch-files/​assets/​executable.txt Adds command-line tool template.

Review effort: Balanced

Comment on lines +457 to +458
if /i "%~1"=="--target" set "_TARGET=%~2" & shift
if /i "%~1"=="--help" call :usage & exit /b 0
Comment on lines +51 to +53
if "%_parOneMyTool%"=="/?" call :_showHelpMyTool & goto _removeBatchVariablesMyTool
if /i "%_parOneMyTool%"=="-h" call :_showHelpMyTool & goto _removeBatchVariablesMyTool
if /i "%_parOneMyTool%"=="--help" call :_showHelpMyTool & goto _removeBatchVariablesMyTool
REM ===================================================================
REM TODO: Replace this section with your tool's logic.
REM ===================================================================
echo Processing: %_parOneMyTool%
Comment on lines +36 to +44
if "%_funcMyLib%"=="/?" call :_showHelpMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="-h" call :_showHelpMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="--help" call :_showHelpMyLib & goto _removeBatchVariablesMyLib

if /i "%_funcMyLib%"=="trimWhitespace" call :_trimWhitespaceMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="toLower" call :_toLowerMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="getTimestamp" call :_getTimestampMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="logMessage" call :_logMessageMyLib & goto _removeBatchVariablesMyLib
if /i "%_funcMyLib%"=="padRight" call :_padRightMyLib & goto _removeBatchVariablesMyLib
if "!_dtMyLib:~3,1!"==" " set "_dtMyLib=!_dtMyLib:~4!"
set "_tmMyLib=%TIME: =0%"
set "_tsMyLib=!_dtMyLib:~6,4!-!_dtMyLib:~0,2!-!_dtMyLib:~3,2! !_tmMyLib:~0,2!:!_tmMyLib:~3,2!:!_tmMyLib:~6,2!"
echo [!_tsMyLib!] [%_argOneMyLib%] %_argTwoMyLib%
set _checkParTwoMyTask=
REM Append new variables above this line.

if EXIST "%_tmpDirMyTask%" rmdir /S /Q "%_tmpDirMyTask%" >nul 2>nul
f"documents `make {target}`, which is not a target in the Makefile.",
source="Makefile")
for whole, inner in CMD_SCRIPT.findall(line):
candidate = (inner or whole).lstrip("./")
Comment on lines +73 to +80
permissions:
pull-requests: write
jobs:
comment:
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@<sha> # data only, not executed
# post results, using the trusted token — but never execute the artifact
Comment on lines +312 to +314
git add CHANGELOG.md
git commit -m "chore: release vX.Y.Z"
git push origin release/vX.Y.Z
| Only internal/private symbols changed | PATCH |
| Type annotation added to previously untyped function | PATCH (non-breaking) |
| Changing default value of optional parameter | Treat as MAJOR if callers might rely on old default |
| Adding a new required config option to an optional block | MINOR if the block itself is optional, otherwise MAJOR |

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants