Added PHPUnit 12 support and fixed tests, fixed PHP8.4 related deprecation notices, formatted to match PSR-12#51
Open
elcreator wants to merge 4 commits into
Open
Added PHPUnit 12 support and fixed tests, fixed PHP8.4 related deprecation notices, formatted to match PSR-12#51elcreator wants to merge 4 commits into
elcreator wants to merge 4 commits into
Conversation
…ation notices, formatted to match PSR-12
|
|
Author
|
All tests passed without failing, Psalm and Code Sniffer were also successfully executed. |
|
Unfortunately my old php 8.1 pull request was never accepted as well. I am assuming that the project maintainer is not active on the project and just touches it every 2 years or so. For anyone that wants to use this PHP 8.4 pull request/fork, you can install it directly from the contributor using this: composer config repositories.garden-cli vcs https://github.com/elcreator/garden-cli
composer require vanilla/garden-cli:dev-master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@acharron-hl I saw PHP8.4 upgrade in the garden-container so upgraded it's version in this repo too.