ci/docker: update nintendo switch buildroot image for theofficialgman…#382
Conversation
|
@itsmattkc thoughts on this build error? your parsing script doesn't work with how I tag my releases |
|
You're free to update the version parsing code if you'd like, it just needs to get the kernel version from somewhere because Nexmon has different kernel modules for each. |
|
seems like I just need to set it since it defaults to the tag when supplied |
|
hmm... that still didn't work even though I manually set the BR2_LINUX_KERNEL_VERSION how did you get this to build before? |
|
It was always working incorrectly. the version before was what is happening now is more expected |
|
ok last failure was not my fault. xorg download from freedesktop servers failed. seems up rn so I'll just re-trigger it. |
|
actually yours didn't fail to download the file so it made it back to nexmon but failed due to not parsing the kernel makefile.... this is not quick/efficient to debug |
Indeed it isn't. I am working on caching most of the build process in a separate branch, however that wouldn't help here since this is still building the system rather than just Vanilla. Your best bet might be running the Docker locally while figuring out the parsing if you can (probably with |
|
@itsmattkc ok so it seems that before my PR, your CI relied on your broken path substitutions to NOT run the nexmon patches under below I simplified that |
|
Huh is that so? I guess as long as the kernel module and firmware installed correctly, that was all that mattered I think you need to resolve merge conflicts with |
|
you don't need to run CI on this PR itself. I already run it on my fork. I'll rebase and adjust changes to fix the conflicts once this is actually tested working. |
|
finally a successful build. will rebase on master now |
|
@itsmattkc don't blindly change boot.scr to something from fedora without actually understanding the changes. I'll revert and adjust so its appropriate. |
only change from noble is the default id to SWR-VAN
|
@itsmattkc partial edit: nevermind regarding changes to buildroot files, because of your this won't catch any upstream files that get git cloned in if you just point to a branch rather than a tag you have to manually change in one of the files in the buildroot folder this also won't catch the few files that go into the images that are outside of the buildroot folder but are still used in the container like files in details on how this functionality works are here https://depot.dev/blog/ultimate-guide-to-docker-build-cache |
Technically I didn't get it from Fedora, I got it from here, which appeared to be a fairly generic/neutral source (and it seemed to work fine when I tested). But fair enough, it's certainly true I didn't pay much attention to what was in either boot.scr (apart from checking if the new one had a fix for #386)
Yeah I figured the Are there files from |
|
Super5 support requires new device tree, boot.scr, and userspace changes. These aren't done and integrated by Azkali yet. When they are done I'll integrate them. A boot.scr update alone isn't enough for all the super5 hardware (new touch, new OLED screens for multiple models, new native supported resolutions). |
|
Build was successful on my fork. So this can be merged. Actually it does look like the run stage rather than the build contains the copying of the gui files so the cache doesn't affect them. |
|
This is testing and working on real hardware. But as I said before, now that the screen is correct, your imu/accel rotation is wrong. The accel/imu is exposed to userspace correctly (go in Linux and you will see iio-sensor-proxy report as "normal" when switch is held normally in landscape). Please adjust your rotation in vanilla as appropriate (which probably means just removing any rotation you were adding). The switch has to be held upside down as it is now to appear looking forward upright in Nintendo land |
|
Just tested it. Looks good to me, thanks! |
|
Oh did my test adjustments fix accel/gyro? I wasn't able to test them yet because docker catching wasn't working on my fork so every build takes hours. |
|
In my tests, yes, the gyro looked right in Nintendo Land |
… kernel fork
the contains the nintendo switch linux kernel fork that has the new hardware level rotation support.
Rotation to landscape when handheld is not handled by the nvidia userspace composition pipeline in xorg anymore but rather by the display controller in hardware.
This fully resolves the framepacing/stutter issue that can be seen in all previous linux for switch distros and is particularly severe in the vanilla (10+ stutters per second).
Currently testing this in github actions. As I changed the build to actually use the compiled devicetrees, rather than a precompiled version from who knows where, it may fail due to wrong paths being supplied.
I will remove the draft state once the build succeeds (testing here https://github.com/theofficialgman/vanilla/actions/runs/25557489131)