Repository navigation
fix(site): derive the announcement pill, and mention photos in the lede - #12
Merged
Merged
Conversation
The pill said "Ten browsers" while the coverage table two sections below said eleven. The sync script derives the headline stat and the README but never covered the pill, so it drifted the moment Naver Whale was added. It is derived now, with a test. The lede also still listed browsers, downloads, desktop and notes, which stopped being the whole set when photos shipped. Both were caught by rendering the page and looking at it, which is the only way this class of error surfaces.
It was appended to the end of the file and landed in TestVendoredCopiesAreInSync, which has no self.expected, so it errored. It belongs with the other published-count assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught by rendering the live site for launch screenshots and actually looking at it.
The announcement pill said "Ten browsers." The coverage table two sections below said eleven. The sync script derives the headline stat and the README count, but I never covered the pill, so it went stale the moment Naver Whale was added. It is derived now and has a test.
That is the third place this number lives. The lesson is not "add the pill", it is that a published claim needs to be derived the first time it is written, not after it drifts.
The lede omitted photos, still listing browsers, downloads, desktop and notes, which stopped being the whole set when the media skill shipped.
All three published counts now agree with the code:
152 tests.