Conversation
kurtmckee
requested review from
ahmedsobeh,
bogdanp05,
mkmkme and
smeso
as code owners
June 27, 2026 13:06
Running `mypy --strict` shows that there are no remaining errors in `valkey.utils`. The `pipeline()` context manager is not used anywhere in the codebase and is not documented anywhere. Rather than trying to add type annotations, it has been removed. `list_keys_to_dict()` is an unnecessary pass-through function. Rather than trying to add type annotations, it has also been removed. `from_url()` is a pass-through function that creates a circular import. It has been moved to `valkey/__init__.py`. Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
kurtmckee
force-pushed
the
type-annotate-utils
branch
from
September 16, 2026 17:42
975a096 to
13221d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
This PR adds type annotations to
valkey.utils. During this work, several functions were found to be unnecessary:pipeline()context manager is not used anywhere in the codebase and is not documented anywhere. Rather than trying to add type annotations, it has been removed.list_keys_to_dict()is an unnecessary pass-through function todict.fromkeys(). Rather than trying to add type annotations, it has been removed.from_url()is a pass-through function toValkey.from_url(), but it creates a circular import. Its definition has been moved tovalkey/__init__.py.Running
mypy --strictshows that there are no remaining errors invalkey.utils.