Replace pull_request_target with pull_request in CI workflows#287
Open
manolo wants to merge 1 commit into
Open
Replace pull_request_target with pull_request in CI workflows#287manolo wants to merge 1 commit into
manolo wants to merge 1 commit into
Conversation
Switch from pull_request_target to pull_request in validation.yml and kubernetes-test.yml. Removes environment gates. Test jobs skip for fork PRs since VAADIN_PRO_KEY is not available in that context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
pull_request_targetwithpull_requestinvalidation.ymlandkubernetes-test.yml.Removes
environment: pr-testsgates from both workflows. All test jobs skip for fork PRs sinceVAADIN_PRO_KEYis not available in that context.test-resultsalso skips for fork PRs to avoid artifact download failures.