refactor: reuse Vaadin environment for PER_CLASS Spring tests#109
Draft
mcollovati wants to merge 1 commit into
Draft
refactor: reuse Vaadin environment for PER_CLASS Spring tests#109mcollovati wants to merge 1 commit into
PER_CLASS Spring tests#109mcollovati wants to merge 1 commit into
Conversation
`SpringBrowserlessTest` rebuilt the Vaadin environment for every test method even under `@TestInstance(PER_CLASS)`, so `SpringBrowserlessPerClassLifecycleTest` could not prove it is created once. Reuse the auto-detecting `BrowserlessTestExtension` via `@ExtendWith` so the environment is created once per class when requested, and strengthen `SpringBrowserlessPerClassLifecycleTest` to assert the same `VaadinService`, `VaadinSession` and `UI` are reused across tests.
mcollovati
force-pushed
the
refactor/spring-per-class-env
branch
from
338c8df to
32495dc
Compare
mcollovati
changed the title
PER_CLASS Spring testsPER_CLASS Spring tests
Contributor
Author
|
Based on #112, this might break existing tests extending |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpringBrowserlessTestrebuilt the Vaadin environment for every test method even under@TestInstance(PER_CLASS), soSpringBrowserlessPerClassLifecycleTestcould not prove it is created once.Reuse the auto-detecting
BrowserlessTestExtensionvia@ExtendWithso the environment is created once per class when requested, and strengthenSpringBrowserlessPerClassLifecycleTestto assert the sameVaadinService,VaadinSessionandUIare reused across tests.