Skip to content

ci: remove debug for public ci jobs#3703

Merged
Alexandr-Solovev merged 5 commits into
uxlfoundation:mainfrom
Alexandr-Solovev:dev/asolovev_ci_public
Jul 22, 2026
Merged

ci: remove debug for public ci jobs#3703
Alexandr-Solovev merged 5 commits into
uxlfoundation:mainfrom
Alexandr-Solovev:dev/asolovev_ci_public

Conversation

@Alexandr-Solovev

@Alexandr-Solovev Alexandr-Solovev commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Trims the public Linux CI build to a release-mode, disk-frugal configuration:

  • Drop --debug symbols from all three build.sh invocations (daal, oneapi_c, oneapi_dpc).
  • Delete the cp -r __work __work_daal step that previously preserved the DAAL intermediate build tree on non-ubuntu-24.04 runners.
  • Clean __work after the DAAL build step (previously only cleaned after the oneAPI steps).

Net effect on LinuxMakeDPCPP (job that produces the shared __release_lnx artifact):

  • Smaller build artifacts (no -g).
  • Lower peak disk usage between steps.
  • Lower peak memory during icx/DPC++ compile — relevant because the SYCL TUs are the primary OOM risk on GitHub-hosted runners.

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexandr-Solovev Alexandr-Solovev changed the title fixes ci: remove debug for public ci jobs Jul 21, 2026
@Alexandr-Solovev
Alexandr-Solovev marked this pull request as ready for review July 21, 2026 12:43
Copilot AI review requested due to automatic review settings July 21, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions CI workflow to stop producing debug-symbol builds for public Linux CI jobs, and adjusts build-directory cleanup to reduce disk usage during the workflow run.

Changes:

  • Removed --debug symbols from multiple .ci/scripts/build.sh invocations in the Linux Make job.
  • Changed build-directory handling by adding rm -rf __work cleanup after builds.

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +67 to +71
- name: Make daal debug
run: |
source /opt/intel/oneapi/setvars.sh
.ci/scripts/build.sh --compiler icx --optimizations ${{ matrix.ISA }} --target daal --debug symbols --jobs 20
if [[ ${{ matrix.runner }} != ubuntu-24.04 ]];then cp -r __work __work_daal;fi
.ci/scripts/build.sh --compiler icx --optimizations ${{ matrix.ISA }} --target daal --jobs 20
rm -rf __work
Comment thread .github/workflows/ci.yml Outdated
Comment on lines +72 to +76
- name: Make onedal debug
id: onedal-dbg
run: |
source /opt/intel/oneapi/setvars.sh
.ci/scripts/build.sh --compiler icx --optimizations ${{ matrix.ISA }} --target oneapi_c --debug symbols --jobs 20
.ci/scripts/build.sh --compiler icx --optimizations ${{ matrix.ISA }} --target oneapi_c --jobs 20
@david-cortes-intel

Copy link
Copy Markdown
Contributor

@Alexandr-Solovev Would this affect the jobs that run ABI checks?

@Alexandr-Solovev

Copy link
Copy Markdown
Contributor Author

@Alexandr-Solovev Would this affect the jobs that run ABI checks?

yes it will be definitely red for 1 commit.

My point that ABI check should help us to avoid incompatibilities for users, and we do not publicly provide debug builds

@Alexandr-Solovev
Alexandr-Solovev merged commit 9d92026 into uxlfoundation:main Jul 22, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants