fix: render unsupported ornamental break fallbacks#274
Closed
uxjulia wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p.ornamental-break-as-textfallback to render instead of being skipped bydisplay: none.Root Cause
Some EPUBs provide ornamental breaks as an SVG image plus a hidden text fallback such as
* * *. CrossInk does not decode SVG images, but it still honored the CSS that hides the fallback paragraph, so the entire ornamental break disappeared.Validation
git diff --checkpio run -e simulatorpio run -e defaultafter initializingopen-x4-sdkin the fresh worktree