fix: avoid oversized web multi-delete requests#273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathspayload.Root Cause
The browser was posting all selected paths as one URL-encoded JSON array to
/delete. With larger selections, that request can exceed the small request/parsing budget on the ESP32-C3 before the firmware deletes anything. Splitting the batch in the browser keeps each request small and reuses the existing single-path delete handler.Fixes #269.
Validation
python3 scripts/build_web.pypio run -e simulatorpio run -e tiny -j1git diff --check