Skip to content

fix: suppress back release from reader settings screens#271

Merged
uxjulia merged 2 commits into
developmentfrom
fix/reader-back-release
Jun 14, 2026
Merged

fix: suppress back release from reader settings screens#271
uxjulia merged 2 commits into
developmentfrom
fix/reader-back-release

Conversation

@uxjulia

@uxjulia uxjulia commented Jun 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Suppress the pending Back release when reader-launched settings screens exit on Back press.
  • Apply the same handling to nested Wi-Fi, font download, KOReader, and keyboard entry flows reachable from the reader.
  • Add an Unreleased changelog note for the reader navigation fix.

Root Cause

Some child screens closed on Back press while their parent screens close on Back release. The same physical button interaction could therefore pop the child immediately, then the parent would see the release event and pop again.

Validation

  • pio run -e simulator
  • pio run -e default
  • git diff --check

Hardware Verification

Open a book, go to Reader Menu > Reader Options > Customize Status Bar, then press Back. Expected behavior is returning to Reader Options only; pressing Back again returns to the Reader Menu.

@uxjulia uxjulia marked this pull request as ready for review June 14, 2026 13:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: baeb58c172

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/activities/settings/FontDownloadActivity.cpp Outdated
@uxjulia uxjulia force-pushed the fix/reader-back-release branch from baeb58c to 8881e1d Compare June 14, 2026 14:09
@uxjulia uxjulia merged commit d44fe4a into development Jun 14, 2026
5 checks passed
@uxjulia uxjulia deleted the fix/reader-back-release branch June 14, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long press back button to show footnotes bug Assigned Back Button shortcut closes on release

1 participant