Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Convert rospy Time difference to seconds to compare with a timeout value#409

Open
ashishraste wants to merge 1 commit into
uuvsimulator:masterfrom
ashishraste:fix/thruster-allocator-timeout-comparison
Open

Convert rospy Time difference to seconds to compare with a timeout value#409
ashishraste wants to merge 1 commit into
uuvsimulator:masterfrom
ashishraste:fix/thruster-allocator-timeout-comparison

Conversation

@ashishraste

Copy link
Copy Markdown

Hi UUV simulator authors,

Thanks for this amazing work!

Could you please review this pull request on the issue below?

Issue: Comparing two rospy Time instances, in thruster-allocator, doesn't produce an appropriate duration when comparing with a configurable timeout value. Error thrown:

TypeError: Cannot compare to non-Duration

Fix: This fix converts the Time difference to seconds so as to have a valid comparison with a timeout value.

@awesomebytes awesomebytes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I'm not a maintainer from this project, I do think this PR is completely correct after checking the type that should be in self.config['timeout'] is float (

).

@ashishraste

ashishraste commented Nov 30, 2020

Copy link
Copy Markdown
Author

Hi @awesomebytes,

Thanks for the review. Will have to wait for the maintainers approval I assume before this gets merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants