csplit: include the file name in output-file errors#13138
Open
eyupcanakman wants to merge 1 commit into
Open
Conversation
csplit leaked the raw OS error when it could not create a split file, e.g. `csplit: IO error: Permission denied (os error 13)`. GNU reports the file name and a plain message: `csplit: xx00: Permission denied`. The file-creation error now carries the file name, and the `IoError` display drops the `IO error:` prefix and the raw `(os error N)` code so the other output paths read the same way. Closes uutils#13118
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13118
csplitleaked the raw OS error when it could not create a split file:GNU reports the file name and a plain message instead:
The file-creation error now carries the file name, and the
IoErrordisplay drops theIO error:prefix and the raw(os error N)code so the other output paths read the same way.