Skip to content

Add undo/redo#129

Open
amir9480 wants to merge 1 commit into
usewaypoint:mainfrom
amir9480:add_undo_redo
Open

Add undo/redo#129
amir9480 wants to merge 1 commit into
usewaypoint:mainfrom
amir9480:add_undo_redo

Conversation

@amir9480

Copy link
Copy Markdown
Contributor

image

There is one limitation that I couldn't fix. after undo/redo, values in the inspect tab are not updating.

@jordanisip jordanisip requested a review from cohitre August 13, 2024 18:15
@jordanisip

jordanisip commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Fantastic work, @amir9480. Appreciate the contribution. I'll leave the actual code review to @cohitre but a couple quick notes from my end:

  • I believe we can use the 'metaKey' keyboard event so it works for the different modifiers on mac vs pc. (Edit: it sounds like metaKey actually maps to the windows key on PC so maybe we'd need (event.ctrlKey || event.metaKey) to support cross-platform keyboard shortcuts?
  • It appears the first block that gets added doesn't activate the undo. I would have expected to undo back to the empty state in this case:

CleanShot 2024-08-13 at 14 27 10@2x

@rabiibrahimi

Copy link
Copy Markdown

Will this be reviewed and merged sometimes ?

@WardenCommander WardenCommander left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up

@azer1ghost

Copy link
Copy Markdown

up

1 similar comment
@rabiibrahimi

Copy link
Copy Markdown

up

@cbyad

cbyad commented May 14, 2026

Copy link
Copy Markdown

I tested on my way and have some issue. I rebuild a new one that works. If the subject still on date I can do a PR for this task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants