Skip to content

Remove collection of unhandled exception error messages from telemetry #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singe wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −9
Open

Remove collection of unhandled exception error messages from telemetry #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5cc2450
Remove support for collecting error messages from posthog
singe Jun 24, 2026
d49d5c6
Refactor error function to remove error_msg parameter
singe Jun 24, 2026
fc2c633
Simplify unhandled exception logging
singe Jun 24, 2026
a2e6df8
Apply greptile's suggestion to remove e
singe Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions strix/interface/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,10 +820,10 @@ def main() -> None:
asyncio.run(run_tui(args))
except KeyboardInterrupt:
exit_reason = "interrupted"
except Exception as e:
except Exception:
exit_reason = "error"
posthog.error("unhandled_exception", str(e))
scarf.error("unhandled_exception", str(e))
posthog.error("unhandled_exception")
scarf.error("unhandled_exception")
raise
finally:
report_state = get_global_report_state()
Expand Down
4 changes: 1 addition & 3 deletions strix/telemetry/posthog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ def end(report_state: "ReportState", exit_reason: str = "completed") -> None:
)


def error(error_type: str, error_msg: str | None = None) -> None:
def error(error_type: str) -> None:
props = {**base_props(), "error_type": error_type}
if error_msg:
props["error_msg"] = error_msg
_send("error", props)
4 changes: 1 addition & 3 deletions strix/telemetry/scarf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,10 @@ def end(report_state: ReportState, exit_reason: str = "completed") -> None:
)


def error(error_type: str, error_msg: str | None = None) -> None:
def error(error_type: str) -> None:
props: dict[str, Any] = {
**base_props(),
"session": SESSION_ID,
"error_type": error_type,
}
if error_msg:
props["error_msg"] = error_msg
_send("error", props)