Skip to content

feat protobuf: mark fmt::formatter<>::parse as constexpr #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oigolovanova wants to merge 3 commits into from
+4 −5
Closed

feat protobuf: mark fmt::formatter<>::parse as constexpr #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22cf23f
commit
oigolovanova Jul 3, 2026
5ae2fdf
enhance json test: improve output formatting for CustomNameToJsonTest…
oigolovanova Jul 3, 2026
44cc2c1
refactor json tests: streamline output formatting for CustomNameToJso…
oigolovanova Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ jobs:
TransactionDeathTest.AccessAfterCommit
TransactionDeathTest.AccessAfterRollback
PostgreCluster.TransactionTimeouts
'*ViaChaosProxy'
HttpClient.HttpsWithCrl
HttpClient.HttpsWithNoClientCa
HttpClient.StatsOnTimeout
Expand Down
8 changes: 4 additions & 4 deletions libraries/protobuf/tests/json/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ inline const /*deliberately non-constexpr*/ bool

template <>
struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::PrintOptions> {
auto parse(fmt::format_parse_context& ctx) {
constexpr auto parse(fmt::format_parse_context& ctx) {
auto it = ctx.begin();
if (it != ctx.end() && *it != '}') {
throw fmt::format_error("invalid format");
Expand All @@ -79,7 +79,7 @@ struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::PrintOptions> {

template <>
struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::ParseOptions> {
auto parse(fmt::format_parse_context& ctx) {
constexpr auto parse(fmt::format_parse_context& ctx) {
auto it = ctx.begin();
if (it != ctx.end() && *it != '}') {
throw fmt::format_error("invalid format");
Expand All @@ -101,7 +101,7 @@ struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::ParseOptions> {

template <>
struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::PrintErrorCode> {
auto parse(fmt::format_parse_context& ctx) {
constexpr auto parse(fmt::format_parse_context& ctx) {
auto it = ctx.begin();
if (it != ctx.end() && *it != '}') {
throw fmt::format_error("invalid format");
Expand All @@ -123,7 +123,7 @@ struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::PrintErrorCode> {

template <>
struct fmt::formatter<USERVER_NAMESPACE::protobuf::json::ParseErrorCode> {
auto parse(fmt::format_parse_context& ctx) {
constexpr auto parse(fmt::format_parse_context& ctx) {
auto it = ctx.begin();
if (it != ctx.end() && *it != '}') {
throw fmt::format_error("invalid format");
Expand Down
Loading