fix build: fix debian protobuf build#1273
Open
Malevrovich wants to merge 1 commit into
Open
Conversation
userver-protobuf-unittest-proto was defined after userver_module() called target_link_libraries with its name. Since the target didn't exist yet, CMake treated it as a plain linker flag and skipped transitive include-directory propagation. The compiler never received -I for the generated protobuf headers directory, causing "proto_json/messages.pb.h: No such file or directory" in parallel builds. Move proto target setup into tests/CMakeLists.txt and add_subdirectory before userver_module() so the target exists when linked against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userver-protobuf-unittest-proto was defined after userver_module() called target_link_libraries with its name. Since the target didn't exist yet, CMake treated it as a plain linker flag and skipped transitive include-directory propagation. The compiler never received -I for the generated protobuf headers directory, causing "proto_json/messages.pb.h: No such file or directory" in parallel builds.
Move proto target setup into tests/CMakeLists.txt and add_subdirectory before userver_module() so the target exists when linked against.
Note: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.