refactor redis: do not copy additional_infos of geo points#1271
Open
mishasychev wants to merge 1 commit into
Open
refactor redis: do not copy additional_infos of geo points#1271mishasychev wants to merge 1 commit into
mishasychev wants to merge 1 commit into
Conversation
mishasychev
commented
Jun 26, 2026
- GeoPoint parsing no longer copies the additional_infos array (now taken by reference) and moves the member string out of the reply.
- ExtractStringElem takes the already-fetched element by reference instead of re-looking it up via at()/GetArray() on every call.
- Replaced std::stod/std::stoi with utils::FromString<> for stricter, exception-consistent numeric parsing of scores and timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.