Repository navigation
test(e2e): assert exact pass counts in the playground scripting specs - #105
Merged
arpit-bruno merged 3 commits intoOct 19, 2026
Conversation
🦋 Changeset detectedLatest commit: 7675f0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| `${api} is not currently supported in the Bruno playground. Please use the Bruno desktop app.`; | ||
|
|
||
| // One entry per call in the unsupported-API script. Reading `bru.runner.iterationData` | ||
| // also warns for the object itself, before `.get()` warns for the method. |
|
|
||
| await expect(page.getByText(/Passed: [1-9]\d*, Failed: 0/).first()).toBeVisible(); | ||
| await expect(page.getByText(/Failed: [1-9]/)).toHaveCount(0); | ||
| await expect(responsePane.testsPanel.getByText('Tests (7), Passed: 7, Failed: 0')).toBeVisible(); |
Contributor
There was a problem hiding this comment.
Please get this by id and let this be equal to 'Tests (7), Passed: 7, Failed: 0'
|
|
||
| await expect(page.getByText(/Passed: [1-9]\d*, Failed: 0/).first()).toBeVisible(); | ||
| await expect(page.getByText(/Failed: [1-9]/)).toHaveCount(0); | ||
| await expect(responsePane.testsPanel.getByText('Tests (10), Passed: 10, Failed: 0')).toBeVisible(); |
|
|
||
| await expect(page.getByText(/Passed: [1-9]\d*, Failed: 0/).first()).toBeVisible(); | ||
| await expect(page.getByText(/Failed: [1-9]/)).toHaveCount(0); | ||
| await expect(responsePane.testsPanel.getByText('Tests (1), Passed: 1, Failed: 0')).toBeVisible(); |
|
|
||
| await expect(page.getByText(/Passed: [1-9]\d*, Failed: 0/).first()).toBeVisible(); | ||
| await expect(page.getByText(/Failed: [1-9]/)).toHaveCount(0); | ||
| await expect(responsePane.testsPanel.getByText('Tests (11), Passed: 11, Failed: 0')).toBeVisible(); |
sachin-bruno
approved these changes
Oct 14, 2026
arpit-bruno
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref BRU-4676
Description
Tightens the playground scripting specs so a case that silently stops running fails the test. The
req,bru, andresspecs used to pass when at least one case passed and none failed.The coverage includes:
bru-object-scripting.spec.tsrequiresTests (7), Passed: 7, Failed: 0.request-object-scripting.spec.tsrequiresTests (10), Passed: 10, Failed: 0.response-object-scripting.spec.tsrequiresTests (11), Passed: 11, Failed: 0for the main script, andTests (1), Passed: 1, Failed: 0for the hidden-header script.bru.getAssertionResultsmust return at least one real pass (statuspass, operatoreq). The spec addsres.statusequals200onget usersfirst, because that request has no assertions.bruAPI warning in the banner: 22 messages. The script calls 21 APIs, and readingbru.runner.iterationDatawarns once for the object before.get()warns for the method.