Repository navigation
ci: make the Play upload retryable and read the play-console environment - #79
Merged
Merged
Conversation
The service account key is in the play-console environment, so the upload job, which asked for `play`, ran with an empty key and failed before reaching Google. The upload moves into its own workflow. release.yml calls it as before, and it can also be run by hand with a release tag: it downloads that release run's bundle and uploads it with the listing and release notes from the tag. A re-run of the release cannot fix a broken upload, because a re-run keeps the workflow file the tag was cut with; this can, without rebuilding or moving the tag. The upload also fails with a plain message when the key is missing, rather than with supply's JSON parse error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service account key is in the play-console environment, so the upload job, which asked for
play, ran with an empty key and failed before reaching Google.The upload moves into its own workflow. release.yml calls it as before, and it can also be run by hand with a release tag: it downloads that release run's bundle and uploads it with the listing and release notes from the tag. A re-run of the release cannot fix a broken upload, because a re-run keeps the workflow file the tag was cut with; this can, without rebuilding or moving the tag.
The upload also fails with a plain message when the key is missing, rather than with supply's JSON parse error.