feat(lint): native config lint command for Flex and Fixed config

[pjcdawkins]

Summary

Replaces the app:config-validate command (aliases validate, lint), which used the platformify library's schema validator and reported a single error at a time, with a new lint command that reports all errors and warnings at once. It runs a JSON-schema check plus semantic checks (relationships, names, types/versions, scripts, web config, dependencies, routes).

It works for both configuration styles:

• Flex (Upsun): .upsun/*.yaml, merged, including tasks.
• Fixed (legacy Platform.sh): .platform.app.yaml files and/or .platform/applications.yaml (list or map form), plus optional .platform/routes.yaml and .platform/services.yaml. The .yml extension is accepted as well as .yaml.

About 8600 lines of this PR are the new internal/lint package - almost entirely copied from the internal AI API project where it has been used in production for ~ 9 months.

In the AI API it only supported "Flex" validation, so the "Fixed" configuration is now normalized into the same shape, so the further checks are shared across both styles.

Project root and style detection

Detection is offline (no API calls) and based on the running CLI's own config plus the files present:

• With no path argument, the project root is the nearest enclosing .git directory (falling back to the current directory), so the command can run from any subdirectory. An explicit path is linted as given. The nearest, not topmost, .git is used so a stray repository higher up the tree cannot hijack the result.
• The directory names come from the CLI config (project_config_flavor, project_config_dir, app_config_file), so vendor/white-label builds work. The style is chosen as: Flex when present, else Fixed, else the build's native format. A first-party build (.upsun or .platform) also recognizes the other first-party format as a migration case; white-label builds use only their own names.
• Fixed detection is anchored at the root (a config directory or a top-level app file), so a stray nested config file (e.g. a test fixture) does not turn an unrelated repository into a project. Nested per-app config files are still collected once a project is confirmed.

Details

• commands/lint.go: the command, taking an optional [path] (or merged Flex config via --stdin), with --format text|json. Exits non-zero on errors.
• internal/lint: the pure linter (CheckDir, CheckContent), Fixed-style loaders, and the embedded Flex/Fixed JSON schemas.
• internal/lint/registry: the image registry. gen.go transforms meta.upsun.com/images into the embedded registry.json.
• make lint-assets refreshes the embedded image registry; make lint-assets-check and a non-blocking CI job fail when it is stale.

Tasks and authorizations

• Tasks (Flex only) are schema-checked and get the same name, type, script and relationship checks as applications, plus: base must be used alone, a run command is required, a task cannot be a relationship target, and a task storage mount must name an application.
• authorizations (on applications, their web and worker containers, and tasks): task allows only operate and needs a resource naming an existing task; env allows only view.

Warnings and messages

• Each issue has a file and line number (also in the JSON output), found by following its path through the parsed YAML. The text output groups issues by file, with the line and path on one line and the message below.
• The !include, !file and !archive tags are resolved as the platform does, confined to the project (including through symbolic links). Issues within included content are reported at the tag.
• Linked Git worktrees and separate clones below the root are skipped; submodules are kept.
• Retired image versions (per meta.upsun.com/images) are warned about; decommissioned or unknown versions are errors.
• A config directory found below the project root (e.g. a nested .platform or .upsun) is warned about, since the platform only reads it at the root.
• A duplicate application name names both source files so the error is actionable.
• A service that no application or task uses is a warning, not an error, since the platform deploys it.
• There is no warning for a missing start command: it is optional, e.g. for static sites.
• The command prints the validated directory on its own line each run.

Out of scope

Folding the Platformify repository into this one is a separate follow-up; only its schemas were copied in for now. They are maintained here from now on, since neither upstream describes newer features: tasks, workload authorizations, egress, OCI image config, container_profile on all containers, the structured stack form (the only one the platform accepts), cron and operation timeouts, the local mount source, and operations in Fixed app config were added, and the Fixed application schema's oneOf for type/stack is changed to anyOf, so a composable image can set both, as documented. The Platformify dependency is still used by the init command.

The meta.upsun.com schema is intentionally not used for validation: it resolves type and version via remote $refs (fetched at runtime, which would break offline use) and duplicates the registry-based type check.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR replaces the legacy app:config-validate (aliases validate, lint) command that delegated to the PHP CLI with a native Go linter that validates both Flex (.upsun/*.yaml) and Fixed (.platform*.yaml) project configurations offline, reporting all issues in one run.

Changes:

• Added a native Cobra command for config linting with --format text|json and optional path/stdin input handling.
• Introduced internal/lint with schema validation + semantic checks (types/versions, scripts, web config, dependencies, routes, relationships, naming), plus Fixed-style normalization and embedded schemas.
• Added tooling/CI to keep embedded registry + schemas in sync with upstream sources.

Reviewed changes

Copilot reviewed 47 out of 48 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Makefile	Adds lint-assets and lint-assets-check targets to refresh/verify embedded registry + schemas.
commands/root.go	Removes legacy Platformify validate command wiring and registers the new native lint command.
commands/list_models.go	Updates help/usage metadata for app:config-validate with path, --format, and --stdin.
commands/lint.go	Implements the new native app:config-validate command (aliases lint, validate) with text/json output.
internal/lint/linter.go	Adds CheckContent and wires schema + semantic checks for Flex-style content.
internal/lint/linter_test.go	Adds tests covering combined lints and common failure cases.
internal/lint/normalize.go	Detects Flex vs Fixed config layouts and dispatches to the appropriate loader/linter.
internal/lint/normalize_test.go	Tests style detection and directory linting behavior.
internal/lint/fixed.go	Loads Fixed-style config files, schema-validates them, normalizes into shared config shape, and runs semantic checks.
internal/lint/fixed_test.go	Tests Fixed-style loading/validation paths and edge cases.
internal/lint/merge.go	Merges `.upsun/*.yaml
internal/lint/merge_test.go	Tests merging behavior and error cases.
internal/lint/yaml.go	Adds YAML→Go decoding and JSON-schema validation helpers with scoped paths.
internal/lint/yaml_test.go	Tests YAML schema validation behavior on valid/invalid content.
internal/lint/result.go	Adds shared Result/Issue types and deterministic formatted output.
internal/lint/names.go	Adds application/service/worker name validation.
internal/lint/names_test.go	Tests name validation rules and error formatting.
internal/lint/types.go	Adds registry-backed type/version validation with Flex-only composable/stack warnings.
internal/lint/types_test.go	Tests type/version validation against a test registry.
internal/lint/relationships.go	Adds relationship target validation and “unused service” detection.
internal/lint/relationships_test.go	Tests relationship validation scenarios.
internal/lint/scripts.go	Adds POSIX shell syntax validation for hooks/commands/cron scripts + start-command warnings.
internal/lint/scripts_test.go	Tests script parsing failures and warning behavior.
internal/lint/web.go	Adds web location key/root path checks and rule regex validation.
internal/lint/web_test.go	Comprehensive tests for web linting rules and error formatting.
internal/lint/routes.go	Adds basic route upstream target/protocol validation.
internal/lint/routes_test.go	Tests route linting scenarios and expected messages.
internal/lint/dependencies.go	Adds dependency section validation (type and empty values).
internal/lint/dependencies_test.go	Tests dependency validation including complex PHP dependency shapes.
internal/lint/config_schema.go	Defines shared decoded config model used by semantic checks.
internal/lint/schema/schema.go	Embeds and loads the Flex JSON schema with sync.Once caching.
internal/lint/schema/schema_test.go	Smoke test that the embedded Flex schema validates a basic config.
internal/lint/schema/fixed.go	Embeds and loads Fixed-style schemas (application/routes/services).
internal/lint/schema/platformsh.application.json	Embedded Fixed application JSON schema.
internal/lint/schema/platformsh.routes.json	Embedded Fixed routes JSON schema.
internal/lint/schema/platformsh.services.json	Embedded Fixed services JSON schema.
internal/lint/registry/registry.go	Embeds registry data and provides parsing + normalization (clean()).
internal/lint/registry/registry_test.go	Smoke test that the embedded registry parses and includes expected entries.
internal/lint/registry/model.go	Defines registry model types and JSON unmarshalling behavior for versions.
internal/lint/registry/model_test.go	Tests registry model parsing helpers and template-friendly mapping.
internal/lint/registry/gen.go	Generator that fetches meta.upsun.com/images and writes registry.json.
internal/lint/registry/registry.json	Embedded minimized registry snapshot consumed by the linter.
internal/lint/testdata/registry.json	Test registry fixture used by type-check tests.
go.mod	Adds new dependencies used by the native linter (schema, regex, shell parser).
go.sum	Updates module checksums for the new/updated dependencies.
.github/workflows/ci.yml	Adds a CI job to fail when embedded lint assets are stale.
CLAUDE.md	Updates repo documentation to include the new native lint command.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 48 out of 49 changed files in this pull request and generated 3 comments.

[upsun-dispatch]

Warning

Changes suggested — 🟡 2 warnings · 3 minor points

🔍 Full review · 49 files reviewed

🔵 Minor points

Not blocking, and no threads opened for these.

• internal/lint/registry/model.go:121 — Registry.ForTemplates, and its comment about "Jinja template access", has no production caller in this repo; it is exercised only by model_test.go and this CLI uses no Jinja templates. It is dead code carried over from the source project whose comment misdescribes how the registry is consumed here.
• CLAUDE.md:70 — This line describes the command as "lint.go: Native config linter (aliases validate, app:config-validate)", implying lint is the canonical name. commands/lint.go sets Use "app:config-validate" with Aliases {"lint", "validate"}, so app:config-validate is canonical and lint is the alias; the doc lists the canonical name among the aliases.
• general — This PR does not merge cleanly onto the base branch: go.mod is in conflict. The branch must be rebased or the go.mod conflict resolved before it can merge. Note that go.mod here promotes dlclark/regexp2/v2, xeipuuv/gojsonschema, and mvdan.cc/sh/v3 from indirect to direct requires, so the conflict must be resolved carefully to keep those direct.

Review details

• Commit: f564f12
• Model: claude-opus-4-8
• Panel: security · correctness · robustness · design

[upsun-dispatch]

Note

Reviewed — No new blocking findings · 3 minor points

🔍 Full review · 50 files reviewed

🔵 Minor points

Not blocking, and no threads opened for these.

• .github/workflows/ci.yml:67 — The lint-assets job runs make lint-assets-check, which first runs make lint-assets (fetching live data from meta.upsun.com via go run gen.go and the platformify schemas via curl) and then git diff --exit-code. Because it re-derives the embedded assets from live upstream on every pull_request, any upstream registry/schema change turns this job red on PRs that never touched lint code, and the job fails outright if those hosts are unreachable during CI.
• .github/workflows/ci.yml:59 — The new lint-assets job pins actions/checkout@v6 and actions/setup-go@v6, while the sibling test, legacy-php, and integration-test jobs in this same file use @v7. The mismatched action versions look unintentional.
• internal/lint/registry/model.go:30 — Image.Docs and the Web, Upstream, Location, Hooks, BuildConfig, and Dependency types it references, plus Image.Description and Image.Configuration, are never populated by gen.go (which writes only name/type/runtime/versions into registry.json) and are never read by any linter check — clean() even blanks Description. They are dead speculative fields carried over from the source project.

Review details

• Commit: 539ea49
• Model: claude-opus-4-8
• Panel: security · correctness · robustness · design

Superseded: the latest Upsun Dispatch review no longer requests changes.

[pjcdawkins]

Rebased on main (the go.mod conflict is resolved, keeping dlclark/regexp2/v2, xeipuuv/gojsonschema and mvdan.cc/sh/v3 as direct requires).

Beyond the review threads above, a codex review pass found several cases where the ported linter rejected valid configuration. Fixed here:

• valkey-persistent was rejected outright. The alias was created inside if _, ok := reg["valkey"]; !ok, but the registry does contain valkey, so the branch never ran. Now keyed on the alias itself, as the redis-persistent block already was.
• mariadb-replica and postgresql-replica rejected every version, with an empty it must be exactly one of: list — they are published upstream without versions of their own. They now track the type they replicate.
• Duplicate worker names across applications were reported as an error. Worker names are scoped beneath their application, so they are tracked separately now and excluded from the duplicate check. They remain valid relationship targets.

Not changed: web location rules are validated with regexp2 (.NET syntax), so PCRE constructs such as (?P<name>...) are rejected. Named groups are rarely used in these rules, so this is left for later.

The same three bugs exist in the AI API, which this package was ported from. Fixed there in platformsh/ai/api!205.

[upsun-dispatch]

Warning

Changes suggested — 🟡 2 warnings · 🔵 4 minor points · ⚪ 1 nitpick

🔍 Full review · 50 files reviewed

⚪ Nitpick

• internal/lint/names.go:48 — The length check is len(value) > maxServiceNameLength (32), so a 32-character name is accepted, but the message says it "should be shorter than 32 characters". The message and the rule disagree at exactly 32 characters; either say "no longer than 32 characters" or tighten the comparison to >=.

Verification

• A realistic Fixed project (.platform.app.yaml with mounts/crons/hooks plus .platform/services.yaml and routes.yaml) normalizes and lints with zero errors — I ran CheckDir against it.
• detectFixed anchors on a root-level config dir or app file, so a nested fixtures/.platform.app.yaml alone yields StyleUnknown (covered by TestDetectStyle).
• findFlexConfigFiles builds globs with path.Join, so the io/fs slash patterns still match on Windows (TestFindFlexConfigFiles_NestedDir).
• printLintResult emits errors/warnings as arrays rather than null and returns errLintFailed exactly when result.HasErrors() (commands/lint_test.go).
• schema/fixed.go propagates a parse failure through fixedErr, so LoadApplication/LoadRoutes/LoadServices never hand back a nil schema silently.

The diff adds substantial unit tests for the new package (names, routes, relationships, types, web, scripts, merge, fixed, normalize, registry, schema) plus commands/lint_test.go, which covers only the JSON printing helper — no test exercises runLint/lintInput, the --format validation, or the explicit-path/FindProjectRoot interaction. The existing CI test job runs make test over all packages and golangci-lint runs on the new files; the new lint-assets job re-derives the embedded registry/schemas from upstream and fails on any diff.

Review details

• Commit: 3fe17b0
• Model: claude-opus-5

---

Review 5 of 10 for this pull request · View the full run

[upsun-dispatch]

Note

Reviewed — No new issues found · 7 still open (1 nitpick)

🔁 Incremental · 2 files reviewed

Outstanding from earlier reviews:

• 🟡 #4093039188 — internal/lint/linter.go:48: Valid Fixed composable-image configs fail linting with a bogus error. — CheckTypes still gates the stack-without-type allowance on style == StyleFlex, so Fixed composable configs fall through to check(app.Type, true) and error with 'type cannot be empty'.
• 🟡 #4093039197 — commands/lint.go:79: An explicit path argument silently lints a different directory. — runLint still calls lint.FindProjectRoot(path) for an explicit argument, so lint apps/frontend still lints the enclosing .git root.
• 🔵 #4093039206 — internal/lint/registry/registry.go:30: A registry parse failure degrades into misleading per-type errors. — registry.Parsed still declares var err error inside the function and assigns only within parsedOnce.Do, so later calls after a parse failure return (nil, nil).
• 🔵 #4093039214 — internal/lint/registry/gen.go:62: Fixed-style projects may be judged against Upsun-only version support. — gen.go is unchanged; the embedded registry is still built from upsun-only statuses and is applied to Fixed-style projects too.
• 🔵 #4093039219 — .github/workflows/ci.yml:67: Unrelated PRs go red when upstream publishes image changes. — The lint-assets job still runs on pull_request; this very push is an instance of the predicted drift — golang:1.25 vanished upstream and three pinned test literals had to be edited.
• 🔵 #4093039224 — commands/list_models.go:147: Machine-readable command list exposes keys in a non-standard shape. — list_models.go still keys the two new options as "--format" and "--stdin" instead of Option.GetName(), unlike every neighbouring entry.
• ⚪ internal/lint/names.go:48: Off-by-one wording misleads users at the boundary length. — names.go still uses len(value) > maxServiceNameLength with a message saying "shorter than 32 characters". (first raised)

Verification

• The regenerated registry.json is still valid JSON in the shape registry.Parse expects (per-type object with name/type/runtime/versions).
• golang:1.25 was dropped from the registry and every occurrence in internal/lint tests was updated to golang:1.26; no remaining lint test pins 1.25.
• clickhouse 25.8 moved from supported to legacy, which checkType still accepts (allVersions = supported + legacy), so no test asserting on 25.8 changes behaviour.
• mariadb/mysql both gained 10.11 consistently, keeping the mysql alias (clean() copies mariadb) in agreement with the embedded data.

This increment adds no tests; it refreshes the embedded registry and edits three literals in internal/lint/linter_test.go to keep TestLint passing. The repository's test workflow job runs the lint package tests, and the lint-assets CI job re-runs make lint-assets-check against live meta.upsun.com.

Review details

• Commits: 3fe17b0..fb70568
• Model: claude-opus-5

---

Review 6 of 10 for this pull request · View the full run

[upsun-dispatch]

Warning

Changes suggested — 🟡 1 warning · ⚪ 1 nitpick · 2 still open

🔁 Incremental · 10 files reviewed

⚪ Nitpick

• commands/lint.go:79 — The explicit [path] argument is only passed through filepath.Abs; nothing checks that it exists or is a directory. lint /no/such/dir or lint .upsun/config.yaml reaches lint.CheckDir, where both detectors simply fail, so the user sees no configuration found in "/no/such/dir" (looked for .upsun/*.yaml, ...) rather than a typo/not-a-directory error.

Outstanding from earlier reviews:

• 🔵 #4093039214 — internal/lint/registry/gen.go:62: Fixed-style projects may be judged against Upsun-only version support. — gen.go still keys status off info.Upsun.Status only, so versions retired on Upsun but live on Platform.sh are absent from the registry used for Fixed configs.
• 🔵 #4093039219 — .github/workflows/ci.yml:67: Unrelated PRs go red when upstream publishes image changes. — The lint-assets job still runs on every pull_request and re-fetches meta.upsun.com/the schemas before failing on any diff.

Verification

• registry.Parsed now stores the parse error in the package-level parsedErr, so repeat calls after a failed parse return the error instead of (nil, nil).
• The two new option entries in innerAppConfigValidateCommand are keyed format/stdin, matching the bare-name convention of Option.GetName() used by the other entries.
• An explicit [path] argument is now linted as given (filepath.Abs), with FindProjectRoot applied only to the default ..
• The name-length message change matches the len(value) > maxServiceNameLength condition, and names_test.go was updated to the new wording.
• Dropping the style parameter leaves no other caller of CheckTypes/runChecks; Style is still used by CheckDir and its tests.

This increment adds one fixed_test.go case (Fixed app with stack and no type, asserting no errors only) and updates types_test.go/names_test.go for the signature and message changes; the test CI job (make test) runs them, and the lint-assets job checks embedded asset freshness. No test asserts the warning set for Fixed-style stack configs, which is why the contradictory warning above is uncovered.

Review details

• Commits: fb70568..11bd88e
• Model: claude-opus-5

---

Review 7 of 10 for this pull request · View the full run

[upsun-dispatch]

Note

Reviewed — No new blocking findings · 🔵 1 minor point · 2 still open

🔁 Incremental · 4 files reviewed

🔵 Minor point

• internal/lint/schema/platformsh.application.json:920 — Relaxing the root constraint from oneOf to anyOf makes name + type + stack valid for any type, not just composable ones. A .platform.app.yaml with name: myapp, type: "php:8.3" and stack: ["php@8.3"] now passes the schema, and no semantic check catches it either: in internal/lint/types.go the stack-related branches only fire when app.Type == "" (warning) or when the type starts with composable (empty-stack warning), so a non-composable type carrying a stack key lints clean and reports "The configuration is valid", even though stack is only meaningful with a composable image. The old oneOf at least rejected the combination (for the wrong reason). Adding a check for stack set with a non-composable type in CheckTypes would restore the coverage the schema change gives up.

Outstanding from earlier reviews:

• 🔵 #4093039214 — internal/lint/registry/gen.go:62: Fixed-style projects may be judged against Upsun-only version support. — Unchanged: gen.go still derives supported/legacy solely from versions.<v>.upsun.status; author states no other brand status exists in the feed.
• 🔵 #4093039219 — .github/workflows/ci.yml:67: Unrelated PRs go red when upstream publishes image changes. — Unchanged: the lint-assets job still runs on every pull_request and lint-assets-check still regenerates registry.json from live meta.upsun.com before diffing.

Verification

• The new os.Stat guard in commands/lint.go rejects a missing path and a non-directory path before CheckDir, settling the earlier typo-path point.
• anyOf with the two required branches still rejects an app file lacking name, so the existing "name is required" test expectation holds (gojsonschema merges the best sub-result errors for anyOf).
• The new composable image with type and stack fixture validates: registry.json has no composable entry, so registry.clean() injects it with ChannelStable "25.11", matching type: "composable:25.11".
• Dropping the three platformify curl lines keeps lint-assets-check coherent — the locally maintained platformsh.*.json files can no longer be reverted by a refresh, and git diff -- internal/lint/schema stays clean.

This increment adds one table case in internal/lint/fixed_test.go (Fixed app with both type and stack, asserting no errors), run by the test job in .github/workflows/ci.yml via make test; the new not-a-directory branch in commands/lint.go has no test covering it.

Review details

• Commits: 11bd88e..22c045e
• Model: claude-opus-5

---

Review 8 of 10 for this pull request · View the full run

[upsun-dispatch]

Note

Reviewed — No new issues found · 2 still open

🔁 Incremental · 2 files reviewed

Outstanding from earlier reviews:

• 🔵 #4093039214 — internal/lint/registry/gen.go:62: Fixed-style projects may be judged against Upsun-only version support. — Code unchanged: gen.go still derives supported/legacy solely from versions.<v>.upsun.status, and the same registry is used for Fixed projects; author declined as there is no other brand data available.
• 🔵 #4093039219 — .github/workflows/ci.yml:67: Unrelated PRs go red when upstream publishes image changes. — ci.yml still runs the lint-assets job on every pull_request, re-fetching live meta.upsun.com and the platformify schemas before the git diff check.

Verification

• The new else if !isComposable && !isStackEmpty(app.Stack) branch cannot fire for a type-less app, since the app.Type == "" + stack branch above still continues.
• isStackEmpty (internal/lint/config_schema.go) handles string/slice/map/nil stacks, so the new warning does not misfire on an empty stack: [] or stack: "".
• The added test case asserts the exact new warning text and path prefix applications.foo.stack, matching the string built in types.go.
• Neither normalize.go nor fixed.go rewrites stack, so Fixed-style configs reach the new branch with the author's own value, not a synthesized one.

The diff adds a table case stack_with_non_composable_type in internal/lint/types_test.go exercising the new warning; it runs in the CI test job (make test) alongside golangci-lint in the same job.

Review details

• Commits: 22c045e..4295257
• Model: claude-opus-5

---

Review 9 of 10 for this pull request · View the full run

[upsun-dispatch]

Note

Reviewed — No new blocking findings · 🔵 1 minor point · 1 still open

🔁 Incremental · 7 files reviewed

🔵 Minor point

• internal/lint/types.go:79 — The new retired-version warning renders the suggestion list from img.Versions.Supported only. For a registry entry whose versions are all retired/legacy (Supported empty — which gen.go can produce whenever upstream marks every version of an image retired), the message degrades to version '7.2' of type 'elasticsearch' is retired; use one of: with an empty list, giving the user no actionable target. The same empty-list rendering applies to the two error messages below it, which now share the supported variable.

Outstanding from earlier reviews:

• 🔵 #4093039214 — internal/lint/registry/gen.go:62: Fixed-style projects may be judged against Upsun-only version support. — Partly mitigated: retired-on-Upsun versions now warn instead of erroring, but gen.go still derives solely from versions.<v>.upsun.status, so a version decommissioned on Upsun yet deployable on Platform.sh is still omitted and errors.

Verification

• VersionInfo.LatestVersion is removed and grep over the repository shows no remaining Go caller, so the deletion compiles.
• slices.Concat(Supported, Legacy, Retired) keeps retired versions out of the unsupported-version error, matching the new TestCheckTypes_RetiredVersion expectation of a warning only.
• The retired lists added to registry.json are sorted newest-first exactly as compareVersions orders them (nodejs 8.9 before 8, 6.10 before 6.9).
• internal/lint/linter_test.go now pins golang:1.26, which is in supported, so the newly added golang retired list (1.25 and older) does not turn those cases into warnings.
• check(path, t, runtime) reports the retired warning under the same path previously used for the error, so worker and service paths are unchanged.

Covered by the test job in .github/workflows/ci.yml (make test); this increment adds TestCheckTypes_RetiredVersion in internal/lint/types_test.go and drops the LatestVersion tests. The regenerated registry.json itself is only checked by the lint-assets job, which this change makes continue-on-error: true, so stale/incorrect embedded assets no longer fail CI.

Review details

• Commits: 4295257..0e8f7c8
• Model: claude-opus-5

---

Review 10 of 10 for this pull request · View the full run

The thread is about version data that isn't available and Upsun-related versions are the main use case anyway.

[pjcdawkins]

@upsun-dispatch review

[upsun-dispatch]

Warning

Changes suggested — 🟡 3 warnings · ⚪ 1 nitpick

🔍 Full review · 54 files reviewed

⚪ Nitpick

• commands/lint.go:75 — When both --stdin and a [path] argument are given, lintInput takes the stdin branch and ignores the path without a word. upsun lint --stdin ./proj lints only stdin, and if stdin is empty it fails with "Empty content" instead of pointing out that the two inputs conflict.

Verification

• registry.Parsed now keeps the parse error in the package-level parsedErr, so later calls return the error rather than (nil, nil).
• The Fixed application schema now uses top-level anyOf for name+type / name+stack, so type: composable alongside stack validates, as the new fixed_test case expects.
• The lint-assets CI job has continue-on-error: true and only regenerates registry.json, so upstream drift does not block PRs.
• The new lint command keeps the Cobra name app:config-validate with the lint/validate aliases, matching the removed platformify command it replaces.

This PR adds unit tests across internal/lint (fixed, normalize, merge, types, tasks, relationships, routes, web, scripts, registry, schema) and commands/lint_test.go for output formatting. The CI test job runs them via make test. The non-blocking lint-assets job checks that the embedded registry is up to date. No test covers quiet mode or JSON output when an operational error occurs.

Review details

• Commit: dfdc681
• Model: claude-opus-5-5

---

View the full run

[pjcdawkins]

@upsun-dispatch review

Superseded: the latest Upsun Dispatch review no longer requests changes.