Repository navigation
Fix ruby inherited methods - #15
Merged
Merged
Conversation
xgoffin
approved these changes
Sep 16, 2026
AlexisMontagne
approved these changes
Sep 16, 2026
tgallice
force-pushed
the
tg/processor-inherited-methods
branch
from
September 16, 2026 14:45
fdaed3d to
689e077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated processors now dispatch only through the
METHODStable (theprocess_<name>methods are gone). When a service extends another one, the child processor inherits from the parent processor.self.class::METHODSonly returns the child's constant, so the parent's methods are never registered.As a result, every inherited method fails with
Unknown function <name>. For example,add_influencersonanalytics.manager.Manager, which extendsbase.EntityManager.Fix
Thrift::Processor#initializenow walks the class ancestors and merges everyMETHODStable it finds. A method defined in the child still takes precedence over the parent's.Tests
Analytics::Thrift::Manager::Processor(analytics-thrift-v20.0.19,base-thrift-v20.1.176):Unknown function add_influencers[skip ci]at the end of your pull request to free up build resources.