Skip to content

rb/thrift: passe string field name value instead symbol - #14

Merged
tgallice merged 1 commit into
masterfrom
tg/union-json-field-name
Sep 15, 2026
Merged

tgallice merged 1 commit into
masterfrom
tg/union-json-field-name

Conversation

@tgallice

Copy link
Copy Markdown
Member

Passe the string field value instead the symbol one for ruby.

To reproduice the issue:

require 'thrift'
require 'influencer/apis/influencer/indexer/v1/indexer/indexer_types'

update = Influencer::Apis::Influencer::Indexer::V1::Indexer::InfluencerUpdate.discard_media(0)

Thrift::Serializer.new(Thrift::SimpleJsonProtocolFactory.new).serialize(update)

Return

'Thrift::JsonProtocol#write_json_string': undefined method 'split' for an instance of Symbol (NoMethodError)
  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

@tgallice
tgallice merged commit 5466c5e into master Sep 15, 2026
8 checks passed
@tgallice
tgallice deleted the tg/union-json-field-name branch September 15, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants