Skip to content

Fix curly {{input}} and implicit this. Add tests for common cell renderers - #287

Open
Elodie-DeMatteis-Upf wants to merge 3 commits into
masterfrom
edm/cd-331
Open

Elodie-DeMatteis-Upf wants to merge 3 commits into
masterfrom
edm/cd-331

Conversation

@Elodie-DeMatteis-Upf

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix curly {{input}} and implicit this. Add tests for common cell renderers

Related to : #

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

Additional Notes

@Elodie-DeMatteis-Upf Elodie-DeMatteis-Upf self-assigned this Oct 7, 2026
@Elodie-DeMatteis-Upf
Elodie-DeMatteis-Upf requested review from a team and phndiaye as code owners October 7, 2026 14:22
@Elodie-DeMatteis-Upf
Elodie-DeMatteis-Upf requested review from OwenCoogan and edouardmisset and removed request for a team October 7, 2026 14:22
@linear-code

linear-code Bot commented Oct 7, 2026

Copy link
Copy Markdown

CD-331

@phndiaye phndiaye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where you able to test it live ? (as this is the legacy hypertable). i think it's still used in one of the performance tables in workflow

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants