Repository navigation
VEL-8465: Remove unused ember-export-application-global - #284
Merged
Merged
Conversation
By default the package exports the app as `window.Dummy` in every build except production. Nothing in the repository references that global or the `exportApplicationGlobal` option, and Ember CLI 4.12's app blueprint no longer includes the package.
phndiaye
requested review from
OwenCoogan,
edouardmisset and
olxmpe
and removed request for
a team
October 5, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the unused
ember-export-application-globaldev dependency, as part of the third-party package review of VEL-8465.By default the addon exports the app as a browser global in every build except production, here
window.Dummyfor the dummy app. Nothing in this repository reads that global or setsexportApplicationGlobal, and Ember CLI 4.12's app blueprint no longer ships the addon.Checks run locally:
pnpm lint:js: passes (Node 24.18)pnpm test:ember --test-port 0: 287 tests, 286 passing, 1 skippedpnpm ember build --silent --environment=production: passesember try:one ember-4.12scenario, which CI runs on this PRRelated to : VEL-8465
What are the observable changes?
Nothing changes for users or for the published package. In the dummy app,
window.Dummyis no longer available in the browser console (development and test builds).🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes
The lockfile diff only drops the importer entry and the package and snapshot entries of the removed package; no other resolution changes.