Repository navigation
Turn off jquery-integration in the dummy app - #486
Merged
JulienVannier66 merged 1 commit intoOct 9, 2026
Conversation
JulienVannier66
requested review from
aprentout and
nathalieArnoux
and removed request for
a team
October 6, 2026 13:45
4 of 8 tasks
phndiaye
approved these changes
Oct 6, 2026
phndiaye
approved these changes
Oct 7, 2026
Member
|
@JulienVannier66 you can pick the version on master here :) |
JulienVannier66
force-pushed
the
jv/cd-304/groundwork-turn-off-jquery-integration-in-the-test-apps-7-repositories
branch
from
October 8, 2026 15:12
e894fac to
eebfadc
Compare
Miexil
approved these changes
Oct 9, 2026
JulienVannier66
deleted the
jv/cd-304/groundwork-turn-off-jquery-integration-in-the-test-apps-7-repositories
branch
October 9, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The dummy app still ran with
jquery-integration: true, so its tests could not prove that the addon works without jQuery. This sets the flag tofalseintests/dummy/config/optional-features.json.The
ember-4.12ember-try scenario forced the flag off throughEMBER_OPTIONAL_FEATURES. That override is now redundant, so it is removed.Related to: CD-304
Related PRs: upfluence/hypertable#285, upfluence/hypertable-extension#55, upfluence/upfluence-web#1580
Checks run locally:
ember test(Ember 3.28): 567 tests, 567 passingember try:one ember-4.12: 567 tests, 567 passingpnpm lint:jsandpnpm tsc --noEmit: passWhat are the observable changes?
None for users or for the published package: only the dummy app and ember-try configs change.
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist