Fix Release builds compiling at -Onone - #1252
Merged
Merged
Conversation
The generated project.yml's Release configuration inherited optimizationLevel from BuildSettings, which defaults to .none. Any project generated without explicitly overriding that default shipped a "Release" build that was never actually optimized. Release now always compiles at -O regardless of optimizationLevel, which is kept only for source compatibility with existing callers. Fixes #1251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimizationLevelfromBuildSettings, which defaults to.none. Any project generated without explicitly overriding that default shipped a "Release" build that was never actually optimized.XcodeGenProjectSpec.swiftnow hardcodesSWIFT_OPTIMIZATION_LEVEL: -Ofor every Release config it emits (single-platform + macOS/iOS/iOS AR/visionOS multi-platform targets).BuildSettings.optimizationLevelis kept only for source compatibility with existing callers and documented as unused by project generation.Fixes #1251
Test plan
swift buildsucceedsswift test --filter BuildSystemTests— 40/40 pass, including newtestReleaseConfigurationAlwaysOptimizesRegardlessOfOptimizationLevel, which reproduces the exact regression (optimizationLevel: .none) and asserts every Release block compiles at-OUntoldXRTest): re-generatedproject.yml/.xcodeprojand confirmedxcodebuild -showBuildSettings -configuration ReleasereportsSWIFT_OPTIMIZATION_LEVEL = -O