fix: escape square brackets in glob paths#913
Closed
ruguoba wants to merge 1 commit into
Closed
Conversation
The escapeSpecialChars function only escaped parentheses () but not square brackets []. This caused picomatch to interpret [Resource] as a character class when path contained directories with square brackets (e.g. FiveM resource groups like [GoodCategoryName]). Fixes #810
|
|
commit: |
Author
|
Closing this PR as it's no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the file path contains square brackets (e.g. FiveM resource groups like
[GoodCategoryName]), thematchGlobsfunction fails becausepicomatchinterprets[Resource]as a character class.Root Cause
The
escapeSpecialCharsfunction insrc/core/utils.tsonly escapes parentheses()but not square brackets[].Fix
Added square brackets to the escape regex:
This ensures paths like
C:/Github/Project/[Resource]/ui/src/component/**/*.vueare properly escaped before matching.Fixes #810