feat: Change open to take a boolean | string#200
Open
atomflunder wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
this is in response to the Issue I opened #199, I went ahead and implemented it, I hope it looks okay. I was not so sure about how to design some aspects, especially the☺️
getURLandgenerateURLhelper functions.If this is not something you wish to implement, feel free to close this PR and the underlying issue
As it stands, this will do:
pnpm listhen .-> opens nothingpnpm listhen . --open-> opens the baseURL (e.g. https://localhost:3000/)pnpm listhen . --open myTest-> opens the baseURL + supplied string (e.g. https://localhost:3000/myTest)resolves #199