Skip to content

Make js compatible with updated print API#815

Merged
ethantkoenig merged 2 commits into
unfoldingWord:developfrom
ethantkoenig:fix/print
Feb 24, 2018
Merged

Make js compatible with updated print API#815
ethantkoenig merged 2 commits into
unfoldingWord:developfrom
ethantkoenig:fix/print

Conversation

@ethantkoenig

Copy link
Copy Markdown
Contributor

@coveralls

coveralls commented Feb 19, 2018

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.6%) to 90.116% when pulling c7242fc on ethantkoenig:fix/print into 686c61b on unfoldingWord-dev:develop.

Comment thread js/project-page-functions.js Outdated
case "test-door43.org.s3-website-us-west-2.amazonaws.com":
api_prefix = "test-";
break;
default:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this change mean that production will always get the the dev- prefix?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... this shouldn't have been pushed, will fix

@da1nerd da1nerd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ethantkoenig
ethantkoenig merged commit 0a115b8 into unfoldingWord:develop Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants