Repository navigation
api: let every signed in user read system information - #55
Merged
Merged
Conversation
GET /system/get required viewer on the system, which only instance owners hold. Team and project members got Forbidden in the domain card, where the DNS record needs the external IP, and in volume expand, which needs the storage limits. Reading it now takes a session and no role. It returns the external IP, version, storage capacity, networking provider, wildcard domain and BuildKit settings. Updating settings still requires editor on the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A project member got
Forbiddenin two places: the DNS record in the domain card and the volume Expand section. Both readGET /system/get, which required viewer on the system. Only the superuser group holds system grants, so every team or project member who is not an instance owner was refused, not only project members.Change
SystemService.GetSettingsno longer checks a system role.GET /system/gettakes a session and nothing else. It returns the external IP, version, storage capacity, networking provider and capabilities, wildcard domain and BuildKit replica and parallelism settings. No secrets.Unchanged:
/systemroutes are session only, so API keys and MCP cannot call them.Tested
GET /system/getanswers 200,PUT /system/settings/updateanswers 403 for a project admin.Not tested in a browser. The dev cluster has no external IP, so
external_ipv4came back empty there.Notes
PUT /system/settings/updateverifies the wildcard domain's DNS before it checks the role, so a member sending a domain gets 400 instead of 403. Nothing is written. Not changed here.