Skip to content

fix: use explicit UI5 version URL to work around legacy-free resource root bug #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nanovsky wants to merge 1 commit into from
Closed

fix: use explicit UI5 version URL to work around legacy-free resource root bug #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/ui5-v2-js-app/webapp/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
<meta http-equiv="Content-Security-Policy"
content="default-src *; style-src * 'self' 'unsafe-inline'; script-src * 'self' 'unsafe-inline' 'unsafe-eval'">

<script id="sap-ui-bootstrap" src="https://ui5.sap.com/1-legacy-free/resources/sap-ui-core.js"
<!-- FIXME: Using explicit version instead of /1-legacy-free/ alias due to UI5 CDN resource root bug. Revert to alias once fixed. -->
<script id="sap-ui-bootstrap" src="https://ui5.sap.com/1.142.2-legacy-free/resources/sap-ui-core.js"
data-sap-ui-theme="sap_horizon" data-sap-ui-resourceroots='{"test.Sample": "./"}'
data-sap-ui-compatVersion="edge"
data-sap-ui-oninit="module:sap/ui/core/ComponentSupport" data-sap-ui-async="true"
Expand Down
8 changes: 8 additions & 0 deletions examples/ui5-v2-js-app/webapp/test/e2e/ui5-late.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ describe("ui5 basic", () => {
await browser.$("#user-content-wdi5-").waitForExist()
// open local app
await browser.url("http://localhost:8082/index.html")

// FIXME: UI5 legacy-free CDN build has broken resource root detection — remove once fixed upstream.
await browser.execute(() => {
if (sap?.ui?.loader) {
sap.ui.loader.config({ paths: { "": "https://ui5.sap.com/1.142.2-legacy-free/resources/" } })
}
})

// do the late injection
await ui5Service.injectUI5()
})
Expand Down
Loading