Fix allControls press() to target specific control with interaction selector#728
Open
iamSmallY wants to merge 5 commits into
Open
Fix allControls press() to target specific control with interaction selector#728iamSmallY wants to merge 5 commits into
iamSmallY wants to merge 5 commits into
Conversation
…selector Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
Co-authored-by: vobu <6573426+vobu@users.noreply.github.com>
mauriciolauffer
requested changes
May 9, 2026
mauriciolauffer
left a comment
Contributor
There was a problem hiding this comment.
Your branch is out-of-date, could you rebase it, please?
Contributor
There was a problem hiding this comment.
Remove this file from your PR, no need to edit package-lock.json here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using allControls with an interaction selector,
press()andenterText()always targeted the first matching control instead of the specific indexed control.Changes
domIdto the id field of selector before calling_interactWithControl.checkboxwithinteraction: press.Fixes #720 .
Notes
enterText. So this pr just fix thepress.