Skip to content

Tempo version 3#3078

Open
AndersJensen-NOAA wants to merge 52 commits into
ufs-community:developfrom
AndersJensen-NOAA:tempo_v3
Open

Tempo version 3#3078
AndersJensen-NOAA wants to merge 52 commits into
ufs-community:developfrom
AndersJensen-NOAA:tempo_v3

Conversation

@AndersJensen-NOAA

@AndersJensen-NOAA AndersJensen-NOAA commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Updates to tempo microphysics version 3: Closes issue: #3109
Closes #3297

Commit Message:

* UFSWM - 
  * UFSATM - 
    * ccpp-physics - 

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal

Git Tracking

UFSWM:

Closes #3109
Closes #3297

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: tempo has its own documentation

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data. New lookup tables are needed

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa:
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Testing Remarks:

  • Skipping Acorn testing due to system unavailability
  • Skipping Gaea C6 due to problems that the service desk is aware of, including errors and jobs stuck in pending state in the queue. These issues are affecting multiple users.
  • Ignoring the failed warnings/remarks CI. There is no increase in warnings, and the increase in remarks is just from remark 10448, the ifort deprecation error.

@github-project-automation github-project-automation Bot moved this to Evaluating in PRs to Process Feb 4, 2026
@AndersJensen-NOAA
AndersJensen-NOAA marked this pull request as draft February 4, 2026 18:44
@AndersJensen-NOAA
AndersJensen-NOAA marked this pull request as ready for review February 19, 2026 22:13
@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA Could you please fill out the PR template if this PR is ready? We can't move the PR forward until we have the info requested in the template. If the PR is not ready, it would be best to convert it to draft form until it is ready.

@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Not Ready in PRs to Process Feb 25, 2026
@AndersJensen-NOAA

Copy link
Copy Markdown
Contributor Author

@AndersJensen-NOAA @grantfirl I sync'd and ran an updated check for increased warnings/remarks. It looks like there is a decrease in warnings (yay!) and an increase in remark 10448, which is an ifort deprecation notice that does not need to be addressed. So once we figure out a plan for enabling control_p8_ugwpv1_tempo_aerosol_hail_intel, this PR should be ready to go.

Sounds good. We could try to increase the memory further and see if that test passes consistently.

@dustinswales

Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA and I discussed adding a regional TEMPO hail aware test in lieu of enabling control_p8_ugwpv1_tempo_aerosol_hail_intel.
@gspetro-NOAA We can remove the control_p8_ugwpv1_tempo_aerosol_hail_intel test and move forward with this PR.
I opened an issue for the new test, #3297

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA and I discussed adding a regional TEMPO hail aware test in lieu of enabling control_p8_ugwpv1_tempo_aerosol_hail_intel. @gspetro-NOAA We can remove the control_p8_ugwpv1_tempo_aerosol_hail_intel test and move forward with this PR. I opened an issue for the new test, #3297

Great! I've removed control_p8_ugwpv1_tempo_aerosol_hail. If you're good with the change, then once systems are back from today's maintenance and #3293 is merged, I think we can go ahead with processing this PR. 🎉

@dustinswales

Copy link
Copy Markdown
Collaborator

@gspetro-NOAA Thanks you.
I didn't notice, but @AndersJensen-NOAA already added a hail aware TEMPO regional test, so we are all ready to go.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@gspetro-NOAA Thanks you. I didn't notice, but @AndersJensen-NOAA already added a hail aware TEMPO regional test, so we are all ready to go.

Awesome! Problem solved! 😄 🎉
Could you look through/approve the UFSATM subPR? (Or point me to a good candidate for that task?)

@gspetro-NOAA gspetro-NOAA moved this from Waiting for Reviews (subcomponent) to Review in PRs to Process Jul 14, 2026
@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Jul 14, 2026
@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@AndersJensen-NOAA @grantfirl @dustinswales Please sync w/develop. Once the PR is sync'd and we have at least one UFSATM sub-PR review, we can get started on this PR.

@gspetro-NOAA gspetro-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed On Deck This is the next PR in line for testing/merge. labels Jul 15, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Jul 15, 2026
@gspetro-NOAA gspetro-NOAA added the In Testing The PR that is currently in testing stages label Jul 15, 2026
@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

Testing is underway now! I just noticed that we will need a commit message for each component by the time testing is done. It should be added to this section of the PR template above:

Commit Message:

* UFSWM - 
  * UFSATM - 
    * ccpp-physics - 

@BrianCurtis-NOAA

Copy link
Copy Markdown
Collaborator

Noting Acorn not available yet. Will check again tomorrow.

@FernandoAndrade-NOAA

Copy link
Copy Markdown
Collaborator

Leaving a note that GaeaC6 is running into errors and jobs stuck in pending within the queue. The support desk is aware and is currently looking into the issues.

@gspetro-NOAA

gspetro-NOAA commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

We will skip Acorn testing (due to system unavailability) and Gaea C6 due issues there. The increase in remarks is from 10448, the ifort deprecation remark and can be ignored. I will post a note in sub-PRs to start the merge process.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

Testing is underway now! I just noticed that we will need a commit message for each component by the time testing is done. It should be added to this section of the PR template above:

Commit Message:

* UFSWM - 
  * UFSATM - 
    * ccpp-physics - 

@AndersJensen-NOAA @grantfirl We are almost ready to merge, so I need this commit message ASAP. :)

@gspetro-NOAA gspetro-NOAA removed the In Testing The PR that is currently in testing stages label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. CCPP There are changes to a CCPP repository. Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. UFSATM There are changes to the UFSATM repository.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

Hail aware TEMPO regional regression test Tempo Microphysics version 3

7 participants