Issue #1346 incorrect xml response from signposting api#1347
Open
kuchtiak-ufal wants to merge 3 commits into
Open
Issue #1346 incorrect xml response from signposting api#1347kuchtiak-ufal wants to merge 3 commits into
kuchtiak-ufal wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the Signposting describedby endpoint to return valid DataCite XML by outputting a single XML root element (matching the configured DataCite dissemination crosswalk), aligning with the upstream DSpace fix for issue #1346.
Changes:
- Switch
/signposting/describedby/{uuid}to useDisseminationCrosswalk#disseminateElement()instead ofdisseminateList()to ensure a single root element is returned. - Strengthen the integration test to assert the response starts with the expected DataCite
<resource ...>root element.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dspace-server-webapp/src/main/java/org/dspace/app/rest/signposting/controller/LinksetRestController.java | Ensures describedby returns a single-root XML document via disseminateElement(). |
| dspace-server-webapp/src/test/java/org/dspace/app/rest/signposting/controller/LinksetRestControllerIT.java | Adds an assertion verifying the DataCite XML root element is present at the start of the response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix is taken from upstream fix in this pull request:
DSpace#10090