LSM9DS1 interrupts#5
Open
seanboe wants to merge 6 commits into
Open
Conversation
Only some very slight changes, but I (at least within main.cpp and the SPIDevice and LSM9DS1 libraries) removed the dependency on the UART.h library since this isn't support for teensy lc. The main change was modifying all references to pin_size_t to uint16_t and adding SPI.begin() to setup.
| } | ||
|
|
||
|
|
||
| void LSM9DS1::setGyroActivity(bool wake) { |
Collaborator
There was a problem hiding this comment.
Review this method and the registers used, please add clarifying comments on the register in the header file
| z = z_raw * resolution / 1000; | ||
| } | ||
|
|
||
| void LSM9DS1::configXLInterrupt(INT_XL_CONFIG intConfig, bool andInterrupt, uint8_t duration) { |
Collaborator
There was a problem hiding this comment.
Read the configuration in the registers here and update those values instead of writing directly to the register to avoid overwriting bits that were already set
| @@ -1,21 +1,24 @@ | |||
| #include <Arduino.h> | |||
Collaborator
There was a problem hiding this comment.
Please migrate main code here to its own test file that we can invoke individually
Collaborator
There was a problem hiding this comment.
Investigate what testing suite or general testing support is offered by PlatformIO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added interrupt functionality to the LSM9DS1 library.